225893 - Autocomplete selects first address in list when user attempts to scroll down.

Status: VERIFIED FIXED

(SeaMonkey :: Autocomplete, defect)

Description

[Howard M. Stark]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6b) Gecko/20031112
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6b) Gecko/20031112

Autocomplete inappropriately selects first address in list when user attempts to
scroll down to find the needed address. It was working correctly in M1.5

Reproducible: Always

Steps to Reproduce:
1.Open Compose window
2.Type a few letters in "To" in order to find the needed address amoung a long
list of addresses. 
3.Dialogue opens with the first few of the appropriate addresses. Assume that
there are more addresses than appears in the list.
4.Try to scroll down to appropriate address from those below and not showing.

Actual Results:  
Autocomplete selects the first name on the list and closes. Get the same result
when using "Cc" or "Bc" or the rest of the choices.

Expected Results:  
Scroll down list to allow user to pick proper address.

Comment 1

[[e-mail]]

Reproduce on Linux trunk build.
Note that this bug only affects mouse scrolling; keyboard scrolling is OK.
I was able to duplicate this bug in the Open Location dialog too.

Comment 2

[Howard M. Stark]

Just checked keyboard scrolling works. It never occured to me to try it. Force
of habit I guess. Sorry

Comment 3

[[e-mail]]

OK, so what's happening is that these days scrollbars now focus their owner, or
something - unfortunately autocomplete isn't expecting the focus to change when
you click on its scrollbar. roc, can you confirm that please?

Comment 4

[Howard M. Stark]

I would if I could, but I don't know how.

Comment 5

[Scott MacGregor]

See the mail version of this bug: 226804 for auto complete in mail compose.

Comment 6

[[e-mail]]

I've got a hunch this is "fallout" from bug 215928. Basically autocomplete
cancels when the input loses focus, and trees like to take focus, so an event
handler was added to catch mousedown events on the tree to prevent the tree from
grabbing focus from the input. I've got two options here: 1) Use a capturing
event handler (which I implemented in xbl instead of using an attribute for
extra brownie points) or 2) Make it so that autocomplete trees don't care about
focus.

Comment 7

[[e-mail]]

Attachment: Proposed patch

Comment 8

[[e-mail]]

Comment on attachment 136901 [details] [diff] [review]
Proposed patch

Patch 2 caused a regression , so I couldn't use it :-/

Comment 9

[[e-mail]]

*** Bug 227637 has been marked as a duplicate of this bug. ***

Comment 10

[Scott MacGregor]

*** Bug 226804 has been marked as a duplicate of this bug. ***

Comment 11

[chris hofmann]

brian, can you catch the review on this?  if its going to make 1.6 need to do it
quickly

Comment 12

[walter sheets]

The mousedown event is what triggers the bug, so I tried deleting
this line from xpfe/global/resources/content/bindings/scrollbar.xml:

<handler event="mousedown" action="event.preventBubble();"/>

and the bug is gone.  Am I re-introducing a bug somewhere else by
doing this?  I haven't spotted anything yet...

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I like Neil's fix. Thanks Neil!

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 136901 [details] [diff] [review]
Proposed patch

r=[e-mail]

This is good because generally should avoid using event handlers on <content>
because if the user specifies a mousedown handler it'll clobber the one that
was set in the XBL binding, which is what I bet was happening here.

Comment 15

[Asa Dotzler [:asa]]

Comment on attachment 136901 [details] [diff] [review]
Proposed patch

a=asa (on behalf of drivers) for checkin to Mozilla 1.6

Comment 16

[[e-mail]]

Fix checked in.

Comment 17

[Mitch]

*** Bug 222091 has been marked as a duplicate of this bug. ***

Comment 18

[[e-mail]]

*** Bug 222702 has been marked as a duplicate of this bug. ***

Comment 19

[Max Alekseyev]

*** Bug 228244 has been marked as a duplicate of this bug. ***

Comment 20

[Mike Cowperthwaite]

*** Bug 228393 has been marked as a duplicate of this bug. ***

Comment 21

[Mike Cowperthwaite]

*** Bug 234097 has been marked as a duplicate of this bug. ***

Comment 22

[Joe Mehaffey]

Ah.. YOu are exactly right!  1.6 has it fixed.  I had looked and had not
realized that there was a new version.  I wish Mozilla had a more obvious rlease
numbering scheme!  Bravo on the fix!

Comment 23

[Jason Bassford]

*** Bug 234097 has been marked as a duplicate of this bug. ***