Closed Bug 225938 Opened 21 years ago Closed 20 years ago

Template version comment outputted before doctype

Categories

(Bugzilla :: Bugzilla-General, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 228894

People

(Reporter: tama, Assigned: justdave)

Details

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007 Firebird/0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007 Firebird/0.7

I've been customising the bugzilla interface to make it Project Manager
friendly. At the top of every template is the following comment:

<!-- 1.0@bugzilla.org -->

Which means Bugzilla is outputting page content before the doctype is written in
header.html.tmpl. I'm not sure if this breaks the XHTML DTD (I haven't looked)
but IE certainly doesn't like it and reverts to quirks mode. I've had to go
through and remove all the <!-- 1.0@bugzilla.org --> comments so the css only
pages will render properly. Maybe these comments could be moved to be template
comments i.e.

[%# 1.0@bugzilla.org %]

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Actual Results:  
n/a
This bug is a duplicated of a WONTFIX (which I can't find right now) because
yes, that is legal in the DTD, as long as there's nothing other than comments
prior to the doctype declaration.

However, the allegation that it breaks Internet Explorer is new information, and
unfortunately might be reason enough to change it even if it's legal :(
Status: UNCONFIRMED → NEW
Ever confirmed: true
I confirm that it breaks IE6... I'm trying to make the templates CSS friendly
and having this in the templates forbids to switch to strict mode and have IE6
use the same CSS box model.

It is something we should fix in order to allow to create interfaces using CSS
that are standard and understood by at least IE6 in the Internet Explorer family..

How about removing these comments and only keep one in the header template after
the DOCTYPE.. 

It also bloats the HTML code.. 
We haven't been updating these versions, and I still claim that 2.16->2.18
involves changing almost every template anyway.....
Resolving as a dupe of the bug which changed all the comments from html to
Template-stylee

*** This bug has been marked as a duplicate of 228894 ***
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.