228894 - [e-mail] comments should be Template comments instead of HTML comments

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

If I wanted to change the DOCTYPE to trigger standards mode in MSIE, having a
comment before the DOCTYPE prevents it.

So, we ought to change all of the <!-- [e-mail] --> comments to be [%#
[e-mail] %]

This would also make the comments uniform across every type of template, even
text and XML, which would make parsing them easier.

We talked about this in #mozwebtools, justdave seems to think it's okay.

I think it's just basically a sed -i and maybe some changes to the testing tools
(the DevGuide claims that the testing tools checks for "[e-mail]" on the
first line of a template, but I didn't go and check how it's done).

-M

Comment 1

[Zach Lipton [:zach]]

This is probably a good idea. I had used HTML comments so that one could
determine  the template version with a simple view source, but since it breaks
IE it should be changed to HTML comments. 

Comment 2

[GavinS]

Attachment: change html comments to template-toolkit ones for template version numbers

Comment 3

[GavinS]

Attachment: script used to do the conversion

Here is the bash/perl script which I used to do the change. I'm attaching this,
so it too can be reviewed as 'doing the right thing', and so can be used on
localised sets of templates, if anyone wants to

Comment 4

[Christian Reis]

Comment on attachment 137932 [details] [diff] [review]
change html comments to template-toolkit ones for template version numbers

Looks okay. I don't actually see why this can't be moved to *after* the doctype
emission (I find having the template version quite interesting once we start
using it), but if `people' have decided that this is the way to go, the changes
look correct. I'll let Dave confirm that.

Make sure a grep -r '<!-- 1.0' returns nothing for your tree.

Comment 5

[Vlad Dascalu]

I can confirm that grepping for the old format returns 0 results.

Comment 6

[Dave Miller [:justdave]]

this should help eliminate some of the spam to [e-mail], too ;)

Comment 7

[GavinS]

I can't checkin, so could someone do that for me? (After the release, I'm guessing? :)

Comment 8

[Vlad Dascalu]

Talked with justdave and it's ok to check it in now.

Thanks Gavin!

Checking in template/en/default/index.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/index.html.tmpl,v  <-- 
index.html.tmpl
new revision: 1.13; previous revision: 1.12
done
Checking in template/en/default/account/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/create.html.tmpl,v
 <--  create.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/account/created.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/created.html.tmpl,v
 <--  created.html.tmpl
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/account/exists.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/exists.html.tmpl,v
 <--  exists.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/account/auth/login.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login.html.tmpl,v
 <--  login.html.tmpl
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/account/email/confirm.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/email/confirm.html.tmpl,v
 <--  confirm.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/account/password/set-forgotten-password.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/password/set-forgotten-password.html.tmpl,v
 <--  set-forgotten-password.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/account/prefs/account.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/account.html.tmpl,v
 <--  account.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/account/prefs/email.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/email.html.tmpl,v
 <--  email.html.tmpl
new revision: 1.11; previous revision: 1.10
done
Checking in template/en/default/account/prefs/footer.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/footer.html.tmpl,v
 <--  footer.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/account/prefs/permissions.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/permissions.html.tmpl,v
 <--  permissions.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/account/prefs/prefs.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/prefs.html.tmpl,v
 <--  prefs.html.tmpl
new revision: 1.12; previous revision: 1.11
done
Checking in template/en/default/admin/flag-type/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/confirm-delete.html.tmpl,v
 <--  confirm-delete.html.tmpl
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/admin/flag-type/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/edit.html.tmpl,v
 <--  edit.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/admin/flag-type/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/list.html.tmpl,v
 <--  list.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/admin/groups/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/create.html.tmpl,v
 <--  create.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/admin/keywords/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/keywords/confirm-delete.html.tmpl,v
 <--  confirm-delete.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/admin/keywords/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/keywords/create.html.tmpl,v
 <--  create.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/admin/keywords/created.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/keywords/created.html.tmpl,v
 <--  created.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/admin/keywords/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/keywords/edit.html.tmpl,v
 <--  edit.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/admin/keywords/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/keywords/list.html.tmpl,v
 <--  list.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/admin/keywords/rebuild-cache.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/keywords/rebuild-cache.html.tmpl,v
 <--  rebuild-cache.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/admin/products/groupcontrol/confirm-edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/products/groupcontrol/confirm-edit.html.tmpl,v
 <--  confirm-edit.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/admin/products/groupcontrol/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/products/groupcontrol/edit.html.tmpl,v
 <--  edit.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/attachment/content-types.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/content-types.html.tmpl,v
 <--  content-types.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v
 <--  create.html.tmpl
new revision: 1.17; previous revision: 1.16
done
Checking in template/en/default/attachment/created.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/created.html.tmpl,v
 <--  created.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/attachment/diff-file.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-file.html.tmpl,v
 <--  diff-file.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/attachment/diff-footer.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-footer.html.tmpl,v
 <--  diff-footer.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/attachment/diff-header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-header.html.tmpl,v
 <--  diff-header.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v
 <--  edit.html.tmpl
new revision: 1.22; previous revision: 1.21
done
Checking in template/en/default/attachment/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/list.html.tmpl,v
 <--  list.html.tmpl
new revision: 1.15; previous revision: 1.14
done
Checking in template/en/default/attachment/show-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/show-multiple.html.tmpl,v
 <--  show-multiple.html.tmpl
new revision: 1.12; previous revision: 1.11
done
Checking in template/en/default/attachment/updated.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/updated.html.tmpl,v
 <--  updated.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/bug/choose.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/choose.html.tmpl,v 
<--  choose.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/bug/comments.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/comments.html.tmpl,v
 <--  comments.html.tmpl
new revision: 1.9; previous revision: 1.8
done
Checking in template/en/default/bug/dependency-graph.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/dependency-graph.html.tmpl,v
 <--  dependency-graph.html.tmpl
new revision: 1.9; previous revision: 1.8
done
Checking in template/en/default/bug/dependency-tree.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/dependency-tree.html.tmpl,v
 <--  dependency-tree.html.tmpl
new revision: 1.9; previous revision: 1.8
done
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
 edit.html.tmpl
new revision: 1.37; previous revision: 1.36
done
Checking in template/en/default/bug/knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/knob.html.tmpl,v  <--
 knob.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/bug/navigate.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/navigate.html.tmpl,v
 <--  navigate.html.tmpl
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/bug/show-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show-multiple.html.tmpl,v
 <--  show-multiple.html.tmpl
new revision: 1.14; previous revision: 1.13
done
Checking in template/en/default/bug/show.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show.html.tmpl,v  <--
 show.html.tmpl
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/bug/time.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/time.html.tmpl,v  <--
 time.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/bug/activity/show.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/activity/show.html.tmpl,v
 <--  show.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/bug/activity/table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/activity/table.html.tmpl,v
 <--  table.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/bug/create/create-guided.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create-guided.html.tmpl,v
 <--  create-guided.html.tmpl
new revision: 1.15; previous revision: 1.14
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v
 <--  create.html.tmpl
new revision: 1.23; previous revision: 1.22
done
Checking in template/en/default/bug/create/created.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/created.html.tmpl,v
 <--  created.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/bug/create/make-template.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/make-template.html.tmpl,v
 <--  make-template.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/bug/create/user-message.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/user-message.html.tmpl,v
 <--  user-message.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/bug/process/bugmail.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/bugmail.html.tmpl,v
 <--  bugmail.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/bug/process/confirm-duplicate.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/confirm-duplicate.html.tmpl,v
 <--  confirm-duplicate.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/bug/process/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/header.html.tmpl,v
 <--  header.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/bug/process/midair.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/midair.html.tmpl,v
 <--  midair.html.tmpl
new revision: 1.9; previous revision: 1.8
done
Checking in template/en/default/bug/process/next.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/next.html.tmpl,v
 <--  next.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/bug/process/results.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/results.html.tmpl,v
 <--  results.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/bug/process/verify-new-product.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/verify-new-product.html.tmpl,v
 <--  verify-new-product.html.tmpl
new revision: 1.12; previous revision: 1.11
done
Checking in template/en/default/bug/votes/delete-all.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/votes/delete-all.html.tmpl,v
 <--  delete-all.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/bug/votes/list-for-bug.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/votes/list-for-bug.html.tmpl,v
 <--  list-for-bug.html.tmpl
new revision: 1.9; previous revision: 1.8
done
Checking in template/en/default/bug/votes/list-for-user.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/votes/list-for-user.html.tmpl,v
 <--  list-for-user.html.tmpl
new revision: 1.12; previous revision: 1.11
done
Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v 
<--  list.html.tmpl
new revision: 1.12; previous revision: 1.11
done
Checking in template/en/default/global/banner.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/banner.html.tmpl,v
 <--  banner.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/global/choose-product.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/choose-product.html.tmpl,v
 <--  choose-product.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/global/code-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/code-error.html.tmpl,v
 <--  code-error.html.tmpl
new revision: 1.36; previous revision: 1.35
done
Checking in template/en/default/global/confirm-user-match.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/confirm-user-match.html.tmpl,v
 <--  confirm-user-match.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/global/footer.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/footer.html.tmpl,v
 <--  footer.html.tmpl
new revision: 1.11; previous revision: 1.10
done
Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v
 <--  header.html.tmpl
new revision: 1.22; previous revision: 1.21
done
Checking in template/en/default/global/help-header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/help-header.html.tmpl,v
 <--  help-header.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/global/help.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/help.html.tmpl,v 
<--  help.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/global/hidden-fields.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/hidden-fields.html.tmpl,v
 <--  hidden-fields.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/global/message.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/message.html.tmpl,v
 <--  message.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/global/messages.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/messages.html.tmpl,v
 <--  messages.html.tmpl
new revision: 1.19; previous revision: 1.18
done
Checking in template/en/default/global/select-menu.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/select-menu.html.tmpl,v
 <--  select-menu.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/global/site-navigation.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/site-navigation.html.tmpl,v
 <--  site-navigation.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/global/useful-links.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/useful-links.html.tmpl,v
 <--  useful-links.html.tmpl
new revision: 1.21; previous revision: 1.20
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v
 <--  user-error.html.tmpl
new revision: 1.43; previous revision: 1.42
done
Checking in template/en/default/list/change-columns.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/change-columns.html.tmpl,v
 <--  change-columns.html.tmpl
new revision: 1.12; previous revision: 1.11
done
Checking in template/en/default/list/edit-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/edit-multiple.html.tmpl,v
 <--  edit-multiple.html.tmpl
new revision: 1.13; previous revision: 1.12
done
Checking in template/en/default/list/list-simple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list-simple.html.tmpl,v
 <--  list-simple.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/list/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list.html.tmpl,v 
<--  list.html.tmpl
new revision: 1.17; previous revision: 1.16
done
Checking in template/en/default/list/quips.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/quips.html.tmpl,v 
<--  quips.html.tmpl
new revision: 1.12; previous revision: 1.11
done
Checking in template/en/default/list/server-push.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/server-push.html.tmpl,v
 <--  server-push.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/list/table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/table.html.tmpl,v 
<--  table.html.tmpl
new revision: 1.16; previous revision: 1.15
done
Checking in template/en/default/pages/linked.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/pages/linked.html.tmpl,v
 <--  linked.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/pages/linkify.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/pages/linkify.html.tmpl,v
 <--  linkify.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/reports/chart.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/chart.html.tmpl,v
 <--  chart.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/reports/components.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/components.html.tmpl,v
 <--  components.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/reports/create-chart.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/create-chart.html.tmpl,v
 <--  create-chart.html.tmpl
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/reports/duplicates-simple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/duplicates-simple.html.tmpl,v
 <--  duplicates-simple.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/reports/duplicates-table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/duplicates-table.html.tmpl,v
 <--  duplicates-table.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/reports/duplicates.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/duplicates.html.tmpl,v
 <--  duplicates.html.tmpl
new revision: 1.14; previous revision: 1.13
done
Checking in template/en/default/reports/edit-series.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/edit-series.html.tmpl,v
 <--  edit-series.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/reports/keywords.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/keywords.html.tmpl,v
 <--  keywords.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/reports/menu.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/menu.html.tmpl,v
 <--  menu.html.tmpl
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/reports/report-table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/report-table.html.tmpl,v
 <--  report-table.html.tmpl
new revision: 1.9; previous revision: 1.8
done
Checking in template/en/default/reports/report.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/report.html.tmpl,v
 <--  report.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/reports/series-common.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/series-common.html.tmpl,v
 <--  series-common.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/reports/series.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/series.html.tmpl,v
 <--  series.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/request/queue.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/request/queue.html.tmpl,v
 <--  queue.html.tmpl
new revision: 1.9; previous revision: 1.8
done
Checking in template/en/default/search/boolean-charts.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/boolean-charts.html.tmpl,v
 <--  boolean-charts.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/search/form.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/form.html.tmpl,v 
<--  form.html.tmpl
new revision: 1.22; previous revision: 1.21
done
Checking in template/en/default/search/knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/knob.html.tmpl,v 
<--  knob.html.tmpl
new revision: 1.14; previous revision: 1.13
done
Checking in template/en/default/search/search-create-series.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-create-series.html.tmpl,v
 <--  search-create-series.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/search/search-help.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-help.html.tmpl,v
 <--  search-help.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/search/search-report-graph.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-report-graph.html.tmpl,v
 <--  search-report-graph.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/search/search-report-select.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-report-select.html.tmpl,v
 <--  search-report-select.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/search/search-report-table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-report-table.html.tmpl,v
 <--  search-report-table.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/search/search-specific.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-specific.html.tmpl,v
 <--  search-specific.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/search/search.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search.html.tmpl,v
 <--  search.html.tmpl
new revision: 1.18; previous revision: 1.17
done
Checking in template/en/default/search/tabs.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/tabs.html.tmpl,v 
<--  tabs.html.tmpl
new revision: 1.2; previous revision: 1.1
done

FIXED.

Comment 9

[GavinS]

Yuk! The attached (and checked-in) patch contained part of a fix for bug#194472. This will 
currently cause a problem in the error message when trying to create a bug in a product with no 
components, but only if the user has rights to edit components, so, thankfully, a rare situation.

Could some kind person either apply the following to undo the broken bit, or apply the first bit of 
the patch on bug#194472. Sorry!

diff -u -r1.43 user-error.html.tmpl
--- template/en/default/global/user-error.html.tmpl	18 Jan 2004 18:39:28 -0000
	1.43
+++ template/en/default/global/user-error.html.tmpl	19 Jan 2004 19:36:16 -0000
@@ -525,8 +525,7 @@
     Sorry; there needs to be at least one component for this product in order
     to create a new [% terms.bug %].
     [% IF UserInGroup("editcomponents") %]
-      <a href="editcomponents.cgi?product=[% product FILTER url_quote %]">
-        Create a new component</a>.
+      <a href="editcomponents.cgi">Create a new component</a>.
     [% ELSE %]
        Please contact [% Param("maintainer") %], giving the name of
        the product in which you tried to create a new [% terms.bug %].

Comment 10

[Dave Miller [:justdave]]

That chunk has been backed out.

Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v
 <--  user-error.html.tmpl
new revision: 1.44; previous revision: 1.43
done

Comment 11

[GavinS]

*** Bug 225938 has been marked as a duplicate of this bug. ***