227283 - Attempting to print when no printer selected for system causes "Unknown Printing Error Occured"

Status: RESOLVED FIXED

(Firefox :: General, defect, P3)

Description

[jbaber]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6a) Gecko/20031027 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6a) Gecko/20031027 Firebird/0.7+

If you do not select a printer for your machine (I have to choose a network
printer on my NT network), trying to print or print preview gives an "unknown
error".  Is there some platform independent way to tell that the error is that
there is no printer installed?

Reproducible: Always

Steps to Reproduce:
1.Uninstall any printers on your system.
2.Try to print anything.

Actual Results:  
A window pops up that says "Unknown printing error occured"

Expected Results:  
A window should pop up that says "You have no default printer selected" or
something.

I understand that this might not be possible to do for something platform
independent.  If so, I apologize.

Comment 1

[José Jeria]

Confirming, this doesnt seem to have been reported before for Firefox.

Comment 2

[James Cridland]

Not a show-stopper, but this is still the case in Mozilla/5.0 (Windows; U;
Windows NT 5.0; en-US; rv:1.7b) Gecko/20040329 Firefox/0.8.0+

Comment 3

[Brian Polidoro]

I had this occur to me and there's another problem associated with it.  When
this happens I cannot close the print preview toolbar.  When I hit the close
button the tab bar closes instead of the print preview toolabr.  Luckily my tabs
don't close or this would be worse.  I open another tab and the tab bar
reappears with my tabs still intact.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040626 Firefox/0.9.1

Putting blocking-aviary1.0 = ? as this could be confusing and frustating because
the error is very ambiguous. Not to mention the toolbar that won't go away.  And
I'd hate to see someone dump firefox because they can't at least get an
informative error message.

Comment 4

[Brian Polidoro]

The print preview toolbar bug is Bug 226973.

Comment 5

[Blake Ross]

-> pierre, who said he'd take a look

Plussing for PR *just to add a string* that says Error: Printer not installed or
something, so we're prepared for l10n freeze.

Comment 6

[chris hofmann]

is a patch avaiable yet?  need to shut down for PR very soon.

Comment 7

[Pierre Chanial]

Attachment: aaronr's trunk patch

this has been fixed on trunk. (not duping to ease PR1.0+ tracking)

Comment 8

[Pierre Chanial]

Comment on attachment 156930 [details] [diff] [review]
aaronr's trunk patch

See bug 203257 for the details, r=ere, sr=tor.

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Does this qualify as a "gecko change" that also needs to go on 1.7br? Ask
someone doing 1.7br approvals and let me know. 

Comment 10

[Pierre Chanial]

mkaply: is this patch needed on the 1.7 branch?

Comment 11

[Mike Kaply [:mkaply]]

I assume that error is already handled in the 1.7 code?

Comment 12

[Pierre Chanial]

Comment on attachment 156930 [details] [diff] [review]
aaronr's trunk patch

mkaply: this patch has not been checked in the 1.7 branch.
Requesting 1.7 branch approval.

Comment 13

[Mike Kaply [:mkaply]]

Comment on attachment 156930 [details] [diff] [review]
aaronr's trunk patch

a=mkaply for aviary and 1.7

Comment 14

[Pierre Chanial]

Fixed on 1.7 branch:
Checking in nsDeviceContextSpecWin.cpp;
/cvsroot/mozilla/gfx/src/windows/nsDeviceContextSpecWin.cpp,v  <-- 
nsDeviceContextSpecWin.cpp
new revision: 3.45.2.2; previous revision: 3.45.2.1

Fixed on aviary:
Checking in nsDeviceContextSpecWin.cpp;
/cvsroot/mozilla/gfx/src/windows/nsDeviceContextSpecWin.cpp,v  <-- 
nsDeviceContextSpecWin.cpp
new revision: 3.45.6.5; previous revision: 3.45.6.4

mkaply: fyi, a patch for bug 240723 (followed by attempts to fix the builds)
have been checked in aviary but not in 1.7)