229105 - cannot open group of tabs

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[Konrad]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl-PL; rv:1.7a) Gecko/20031220
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pl-PL; rv:1.7a) Gecko/20031220

Im my bookmarks I have few "group of tabs" position. When I try to open it,
nothing happens. When I try one more time, in new tab open only one (first) page
from group.

Also when I have opened few tabs ond click right button of mouse and choose
"close other tabs", nothing happens. When I try one more time, Mozilla closes
only last tab.

Reproducible: Always

Steps to Reproduce:

Comment 1

[HJ]

Konrad, what errors do you see after this action on your JavaScript console?

Comment 2

[Konrad]

Now everything works great :-\ So maybe my bug is invalid :-|

Comment 3

[Konrad]

ok, now i have this bug again. JavaScript console says:

Error: uncaught exception: [Exception... "Index or size is negative or greater
than the allowed amount"  code: "1" nsresult: "0x80530001
(NS_ERROR_DOM_INDEX_SIZE_ERR)"  location:
"chrome://global/content/bindings/tabbrowser.xml Line: 919"]

Comment 4

[Oliver Klee]

Confirming ... I've seen this on my recent Linux CVS build once.

Comment 5

[Oliver Klee]

Just had this bug on a 20031220 Linux CVS build (with the same error message).

My steps (just for the record ... haven't tried to reproduce the bug):
1. Have a browser windows with 2 tabs.
2. Open a new browser windows.
3. Open a tab group.

Result:
1st tab is empty, 2nd and 3rd tab are filled with the 1st tab from the tab group.

Comment 6

[HJ]

This is introduced after the patch for bug 179787.

CC'ing Neil, because he is the one who introduced this side effect...

Comment 7

[[e-mail]]

Attachment: Proposed patch

Comment 8

[HJ]

Comment on attachment 137818 [details] [diff] [review]
Proposed patch

Yep, this patch fixed this bug. Lets get this in a.s.a.p.

Note that <tabbox selectedIndex="0" .. had also worked, if I'm correct.

Btw, any luck with that crasher?

Comment 9

[HJ]

"Note that <tabbox selectedIndex="0" .. had also worked, if I'm correct."

No you fool, that's another bug you're working on (:

Comment 10

[dales]

I can confirm this bug is also present in the Mac OS X builds for 12/21 and 12/22.
It shows the same error in the JavaScript Console as reported previously for the
Linux builds.

Dale

Comment 11

[Oliver Klee]

->OS=All

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 137818 [details] [diff] [review]
Proposed patch

ARRRGH.  More magic undocumented stuff.

sr=bzbarsky, I guess....  I've added a note about this to bug 229043

Comment 13

[[e-mail]]

Fix checked in.