229241 - Bookmarks menu fails to collapse if bookmark is middle clicked

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Haris Karahristianidis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031221 Firebird/0.7+ (MozJF)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031221 Firebird/0.7+ (MozJF)

When I middle click on a Bookmark, tab opens, but Bookmarks stay open till I
click somewhere else

Reproducible: Always

Steps to Reproduce:
1.Middle click on a bookmark
2.Tab opens
3.Bookmarks are still visible
Actual Results:  
Bookmarks stay open

Expected Results:  
Bookmarks should disappear

Comment 1

[Jason Barnabe (np)]

WFM Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031216
Firebird/0.7+

Haris, can you try with a new profile? Also, do you have any extensions installed?

Comment 2

[Haris Karahristianidis]

I have clean install. Only extension is Paste and Go

Comment 3

[rindolf2]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20031225 Firebird/0.7+

This happens for me too. Tested on a clean profile. No extensions. A bit of
clarification: When you middle-click a bookmark from the bookmarks menu, the
menu stays open. All submenus close, however, leaving just the top level
Bookmarks menu open. This does not happen when right-clicking and selecting
"open in new tab", and it doesn't happen on folders in the bookmarks toolbar.

Comment 4

[Greg Campbell]

I can confirm this bug on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.7a) Gecko/20040101 Firebird/0.7+ (aebrahim). It happened on a trunk build
on 20031231 too. I always use a new profile.

This didn't happen on 20031216 (last official trunk), as states comment 1. This
must be a pretty recent regression. Someone should check and make sure this
isn't on the branch.

Comment 5

[Jason Barnabe (np)]

*** Bug 229997 has been marked as a duplicate of this bug. ***

Comment 6

[Petey]

Confirming

Comment 7

[Mike Connor [:mconnor]]

morphing summary.  This only affects the Bookmarks menu, not the BTF or other
locations.  Probably fallout from the fix for 210910

Comment 8

[Jeff Walden [:Waldo]]

*** Bug 230868 has been marked as a duplicate of this bug. ***

Comment 9

[Jeff Walden [:Waldo]]

In response to comment 4, it is in the branch.  I see it in the 20040114 Windows
branch build:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040114 Firebird/0.7+

Seeing as a good fix for bug 210910 will probably be a big point in the 0.8
release notes, this needs to be fixed before 0.8, methinks.  I'm setting a
blocking0.8? flag.  <speculate>I wouldn't think this would be especially hard to
fix, although I could be wrong.</speculate>

Comment 10

[Brian Earley]

Must be a regression. WFM on the milestone: Mozilla/5.0 (Windows; U; Windows NT
5.1; en-US; rv:1.5) Gecko/20031007 Firebird/0.7

Comment 11

[Tadeu "Tcmjr"Junior]

As of Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040115
Firebird/0.8.0+ I do have this problem too.
Also the arrow from the bookmarks -> are missing.

Comment 12

[Bill Gianopoulos [:WG9s]]

This regresssed between the 12/18 and 12/19 windows branch builds. 
Unfortunately, I suspect this is as a result of the fix for the infamous bug
210910 (right click on bookmark).

Comment 13

[Bradley Chapman (not reading bugmail, still gone but not forever)]

Why is this a bug? I happen to think that it's a very useful feature that lets
you open multiple background-tabbed bookmarks in one go.

Comment 14

[Bill Gianopoulos [:WG9s]]

1. Because it does not alow you to do that.  It does not leave the folder with
the bookmark you just clicked on open.  It closes that.  Just the top level
bookmark dropdown fails to close.

2.  Because it is not consistant.  If that is the desired behavior then it needs
to work the same way if you middle click on a bookmark in a folder on your
bookmarks toolbar.  It does not.

3.  It would need to be documented somewhere.

4.  If you left click on the bookmark and select open in a new tab it would need
to leave the menu open.  It does not.

Comment 15

[Pierre Chanial]

marking fixed on branch and trunk.
Please we need a lot of testing since I modified a part of the code prone to
regressions such as 210910.

Comment 16

[Jeff Walden [:Waldo]]

I haven't noticed any regressions from this, so the patch seems good.  WFM now
in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040120
Firebird/0.7+, so removing blocking0.8? flag.

Comment 17

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change