230468 - RFE: mozilla should provide a simple way to run custom shell scripts at mozilla startup and shutdown

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, enhancement)

Description

[Roland Mainz]

RFE: mozilla should provide a simple way to run custom shell scripts at mozilla
startup and shutdown

Possible purposes:
- Set/Unset font paths
- Set additional environment variables without modifying the mozilla scripts
directly
- Start and stop additional applications/shell scripts before mozilla startup
and after shutdown

Design:
The new functionality should work like this:
- Placing a script "S01" into ${MOZILLA_FIVE_HOME}/init.d/ cases the script to
be executed at Mozilla startup.
- Placing a script "K01" into ${MOZILLA_FIVE_HOME}/init.d/ cases the script to
be executed at Mozilla shutdown.
- Startup/shutdown scripts ending with *.sh will be executed "inline" as part of
"run-mozilla.sh", being able to set/alter existing env variables to fix the
needs of the user.

Comment 1

[Roland Mainz]

Attachment: Patch for 2004-01-07-trunk

Note that this new patch does not affect the GRE setup in any way so the
"political" problems ("no scripts used by GRE. Never. Ever!") discussed in bug
226803 do not apply here.

Comment 2

[Roland Mainz]

Comment on attachment 138678 [details] [diff] [review]
Patch for 2004-01-07-trunk

Requesting r= ...

Comment 3

[Roland Mainz]

Attachment: Better patch for 2004-01-07-trunk

The new patch allows that other consumers of the script can set their own value
for MOZ_USER_DIR and run-mozilla.sh is now called inline, saving a few CPU
cycles.

Comment 4

[Benjamin Smedberg]

Comment on attachment 138681 [details] [diff] [review]
Better patch for 2004-01-07-trunk

ok, I'm convinced this is OK for the seamonkey client. Please don't check this
in without MOA=leaf.

Comment 5

[Roland Mainz]

Comment on attachment 138681 [details] [diff] [review]
Better patch for 2004-01-07-trunk

Requesting moa=leaf ...

Comment 6

[Roland Mainz]

Comment on attachment 138681 [details] [diff] [review]
Better patch for 2004-01-07-trunk

leaf: ping!

Comment 7

[Daniel (Leaf) Nunes]

Comment on attachment 138681 [details] [diff] [review]
Better patch for 2004-01-07-trunk

super-rheeet=leaf

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in Makefile.in;
/cvsroot/mozilla/xpfe/bootstrap/Makefile.in,v  <--  Makefile.in
new revision: 1.248; previous revision: 1.247
done
Checking in mozilla.in;
/cvsroot/mozilla/xpfe/bootstrap/mozilla.in,v  <--  mozilla.in
new revision: 1.4; previous revision: 1.3
done

Comment 9

[Hermann Schwab]

could this have caused Bug 233014, starting BuildID 1.7.0.2004020317 ?
Bug 233014 default install into windows\program files directory, erases files 

Comment 10

[Bernd]

has this patch been tested under windows ?

Comment 11

[Roland Mainz]

Hermann Schwab wrote:
> could this have caused Bug 233014, starting BuildID 1.7.0.2004020317 ?
> Bug 233014 default install into windows\program files directory, erases files

How should this patch affect windows ? The script is AFAIK only used on
Unix/Linux ...

Comment 12

[Roland Mainz]

Bernd wrote:
> has this patch been tested under windows ?

No... the only thing I did was to search the windows ZIP archives whether the
script is present in these tarballs. Since there were no hit I assumed Windows
is not affected by this change.

Comment 13

[cls]

When using 'make install' to install a build, I wind up with these extra init.d
dirs under /usr/local/bin/ .  Since those are mozilla specific, they should be
placed under the $mozappdir not $bindir .

Comment 14

[Roland Mainz]

cls wrote:
> When using 'make install' to install a build, I wind up with these extra 
> init.d dirs under /usr/local/bin/ .  Since those are mozilla specific, they 
> should be placed under the $mozappdir not $bindir

OK; I'll fix that as part of bug 234124 ("RFE: Port the pluggable shell script
API to FireFox/ThunderBird/SunBird etc") ...