234124 - RFE: Port the pluggable shell script API to FireFox/ThunderBird/SunBird etc

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, enhancement)

Description

[Roland Mainz]

RFE: Port the pluggable shell script API to FireFox/ThunderBird/SunBird etc
The original functionality was added in bug 230468 and allows various new
functionality like the Solaris patch checker (see bug 230598), XPIs which
provide fonts (see bug 233950 for the MathML XPI, I already demonstrated a Hindi
font XPI for the CTL builds) and stuff like the Xprint XPI (e.g. deamon-like
addons).

Comment 1

[Roland Mainz]

Taking myself...

Comment 2

[Roland Mainz]

Attachment: Patch for 2004-02-13-trunk

Comment 3

[Roland Mainz]

Comment on attachment 141350 [details] [diff] [review]
Patch for 2004-02-13-trunk

Requesting r=/sr= ...

Comment 4

[Roland Mainz]

Requesting inclusion of the patch into 1.7a that all branches made from 1.7a get
that change, too.

Risk is low, we're only porting existing and tested functionality from Mozilla
to FireFox/ThunderBird and the patch only consists of a shell script +
Makefile.in change, no native code is being touched.

Comment 5

[Benjamin Smedberg]

Comment on attachment 141350 [details] [diff] [review]
Patch for 2004-02-13-trunk

I am not a fireblah peer.

Comment 6

[Andrew Schultz]

Comment on attachment 141350 [details] [diff] [review]
Patch for 2004-02-13-trunk

>+      for i in ${dist_bin}/init.d/S* ${HOME}/${MOZ_USER_DIR}/init.d/S* ; do

this is broken if there are spaces in dist_bin, HOME or MOZ_USER_DIR
this would fix it:
	for i in "${dist_bin}"/init.d/S* "${HOME}/${MOZ_USER_DIR}"/init.d/S* ;
do
(or anything that puts the variables in "" but excludes the '*')

Comment 7

[Roland Mainz]

Andrew Schultz wrote:
> (From update of attachment 141350 [details] [diff] [review])
> >+      for i in ${dist_bin}/init.d/S* ${HOME}/${MOZ_USER_DIR}/init.d/S* ; do
>
> this is broken if there are spaces in dist_bin, HOME or MOZ_USER_DIR

Nice catch... :)

Comment 8

[Roland Mainz]

Attachment: New patch per Andrew Schultz's comments

Comment 9

[Pierre Chanial]

Comment on attachment 141516 [details] [diff] [review]
New patch per Andrew Schultz's comments

for build issues, bryner is the One :)

Comment 10

[Roland Mainz]

Attachment: New patch per cls's comments

Comment 11

[Roland Mainz]

Comment on attachment 141788 [details] [diff] [review]
New patch per cls's comments

Wonderfull.
Pro:
People seems to like the new init.d/ feature. Lots of feedback and questions
are coming in.
Contra:
Now they want fixes, documentation and a stable "API"... ;-/

New patch in a few hours...

Comment 12

[Roland Mainz]

Attachment: New patch, hopefully fixing all issues, complains, requests, etc., adding ABI spec and a usefull item for calendar folks to cure an annoying problem

Comment 13

[Roland Mainz]

Attachment: New patch per IRC feedback

Comment 14

[Roland Mainz]

Comment on attachment 141813 [details] [diff] [review]
New patch per IRC feedback

Requesting r=/sr= and checkin= ...

Comment 15

[Roland Mainz]

Attachment: Another round of changes, patch for 2004-02-20-trunk

Comment 16

[Philip K. Warren]

Patch checked in for Roland.