Closed Bug 232597 Opened 21 years ago Closed 21 years ago

In <msgViewPickerOverlay.js>, remove unused |const kPersonalAddressbookURI|

Categories

(SeaMonkey :: MailNews: Message Display, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.7alpha

People

(Reporter: sgautherie, Assigned: sgautherie)

Details

Attachments

(1 obsolete file)

Spun off from bug 162432 comment 47.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.7alpha
Fixes
{{
Error: redeclaration of const kPersonalAddressbookURI
Source File: chrome://messenger/content/msgViewPickerOverlay.js
Line: 23
--> ABSearchDialog.xul
    -> mailWindowOverlay.xul <- contents.rdf.in <- msgViewPickerOverlay.xul ->
msgViewPickerOverlay.js -> kPersonalAddressbookURI  // removed (useless !!)
    -> abCommon.js -> kPersonalAddressbookURI ! (used)
{
/mailnews/extensions/mailviews/resources/content/msgViewPickerOverlay.xul, line

31 -- <script src="chrome://messenger/content/msgViewPickerOverlay.js"/>

/mailnews/extensions/mailviews/resources/content/contents.rdf.in, line 26 --
<RDF:li>chrome://messenger/content/msgViewPickerOverlay.xul</RDF:li>

Question: <mailWindowOverlay.xul> "used" in many places...
http://landfill.bugzilla.org/mxr-test/seamonkey/search?string=mailWindowOverlay.xul&find=&filter=


Answer: Safe to remove, after cross-checking:
http://landfill.bugzilla.org/mxr-test/seamonkey/search?string=kPersonalAddressbookURI&find=&filter=

http://landfill.bugzilla.org/mxr-test/seamonkey/search?string=abCommon.js&find=&filter=

}
}}
When opening "Tools > Search Adresses...".
Attachment #140196 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #140196 - Flags: review?(neil.parkwaycc.co.uk) → review+
Attachment #140196 - Flags: superreview?(sspitzer)
Attachment #140196 - Flags: superreview?(sspitzer) → superreview?(mscott)
Attachment #140196 - Flags: superreview?(mscott) → superreview+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Attachment #140196 - Attachment description: (Av1) <msgViewPickerOverlay.js> → (Av1) <msgViewPickerOverlay.js> [Checked in: Comment 2]
Attachment #140196 - Attachment is obsolete: true
Severity: trivial → normal
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: