233721 - Port of Firefox bug 182928 to Seamonkey (Add confirmation for Set As Wallpaper)

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, enhancement)

Description

[Stefan Borggraefe]

See Firefox bug 182928.

I think this is a good idea and there is no reason Seamonkey shouldn't have
this, too.

Comment 1

[Stefan Borggraefe]

Attachment: Patch

Comment 2

[timeless]

Comment on attachment 141068 [details] [diff] [review]
Patch

>+      var promptTitle   = gNavigatorBundle.getString("wallpaperConfirmTitle");
use two strings. just because en-US can share a string doesn't mean some other
language won't need different messages.

>+      var buttonPressed = promptService.confirmEx(window, promptTitle, promptMsg,
>+                                                   (promptService.BUTTON_TITLE_IS_STRING * promptService.BUTTON_POS_0) +
>+                                                   (promptService.BUTTON_TITLE_CANCEL    * promptService.BUTTON_POS_1),
>+                                                   promptTitle, null, null, null, {value:0});


>Index: xpfe/communicator/resources/locale/en-US/contentAreaCommands.dtd
>-<!ENTITY setWallpaperCmd.label        "Set As Wallpaper">
>+<!ENTITY setWallpaperCmd.label        "Set As Wallpaper...">

Confirm does not count as requiring an ellipsis (i.e. don't make this change).
File>Exit and File>Close window prompt, but they (correctly) don't have
ellipsis.

>Index: xpfe/browser/resources/locale/en-US/navigator.properties
>+#nsContextMenu.js (setWallpaper confirmation dialog)
>+wallpaperConfirmTitle = Set Wallpaper
>+wallpaperConfirmMsg   = Do you want to set this image as your desktop wallpaper?

+wallpaperConfirmButton

Comment 3

[Stefan Borggraefe]

Attachment: Addressed review comments

Comment 4

[[e-mail]]

Comment on attachment 141129 [details] [diff] [review]
Addressed review comments

>+wallpaperConfirmTitle  = Set Wallpaper
Set As Wallpaper, please.

Comment 5

[Stefan Borggraefe]

Attachment: Added the "As"

Otherwise unchanged. I'll transfer Neil's r+ to this patch.

Comment 6

[[e-mail]]

Fix checked in.