Closed
Bug 235472
Opened 21 years ago
Closed 21 years ago
Make the filter dialog size in proportion to the font size
Categories
(MailNews Core :: Filters, defect)
MailNews Core
Filters
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.7beta
People
(Reporter: mscott, Assigned: Stefan.Borggraefe)
References
Details
Attachments
(2 files, 2 obsolete files)
|
32.17 KB,
image/png
|
Details | |
|
2.07 KB,
patch
|
neil
:
review+
mscott
:
superreview+
|
Details | Diff | Splinter Review |
screen shot of the problem with large fonts
http://bugzilla.mozilla.org/show_bug.cgi?id=233028#c10
Thanks for looking into this Stefan!
|
Reporter | |
Comment 1•21 years ago
|
||
|
Assignee | |
Updated•21 years ago
|
Severity: normal → trivial
Status: NEW → ASSIGNED
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → mozilla1.7beta
|
|
Assignee | |
Comment 2•21 years ago
|
||
The FilterListDialog also has a default size that is not proportional to the
used font size. This patch fixes both dialogs.
|
|
Assignee | |
Updated•21 years ago
|
Attachment #142215 -
Flags: review?(neil.parkwaycc.co.uk)
|
||
Comment 3•21 years ago
|
||
Comment on attachment 142215 [details] [diff] [review]
Patch
Could you reduce those sizes slightly, e.g. 48em to 45em?
|
|
Assignee | |
Comment 4•21 years ago
|
||
Ok, I reduced the sizes a little bit. This should still fit.
FYI: The configuration which needed the most space in my tests was Classic
mozilla-theme on a Linux gtk1 build with the Geramik gtk-theme. This
configuration needed even more space than using Classic with Windows XP.
|
|
Assignee | |
Updated•21 years ago
|
Attachment #142215 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•21 years ago
|
Attachment #142215 -
Flags: review?(neil.parkwaycc.co.uk)
|
|
Assignee | |
Updated•21 years ago
|
Attachment #142337 -
Flags: review?(neil.parkwaycc.co.uk)
|
|
||
Comment 5•21 years ago
|
||
Comment on attachment 142337 [details] [diff] [review]
Patch V1.1
I've just twigged that the old width= height= dimensions apply to the outer
dimensions, but the styled dimensions apply to the inner dimensions; this
doesn't matter much for the width but the window still looks too tall because
of the title bar. Please could you shorten both windows another couple of em?
|
|
Reporter | |
Comment 6•21 years ago
|
||
*** Bug 235699 has been marked as a duplicate of this bug. ***
|
|
Assignee | |
Comment 7•21 years ago
|
||
Reduced height of both windows by 3em.
Attachment #142337 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•21 years ago
|
Attachment #142337 -
Flags: review?(neil.parkwaycc.co.uk)
|
|
Assignee | |
Updated•21 years ago
|
Attachment #142352 -
Flags: review?(neil.parkwaycc.co.uk)
|
|
||
Comment 8•21 years ago
|
||
Comment on attachment 142352 [details] [diff] [review]
Patch V1.2
Goldilocks and the Three Patches... this one's Just Right ;-)
Attachment #142352 -
Flags: review?(neil.parkwaycc.co.uk) → review+
|
|
Reporter | |
Comment 9•21 years ago
|
||
Comment on attachment 142352 [details] [diff] [review]
Patch V1.2
lol...thanks a lot guys
Attachment #142352 -
Flags: superreview+
|
|
Assignee | |
Comment 10•21 years ago
|
||
Scott: Could you check this in (and perhaps the patch for bug 223295, too)?
Thanks! :-)
After some web-searching I now know about Goldilocks, too. She's unknown in
Germany or at least to me. So at least I learned something new by doing *three*
patches for this bug. ;-)
|
|
Reporter | |
Updated•21 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: MailNews → Core
|
||
Updated•17 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•