237510 - installer exits on "pause" and before Connection Dropped dialog can be seen

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Andrew Schultz]

the pause feature while downloading currently doesn't work.  With linux trunk
2004031408, the installer simply exists if you hit pause.  For similar reasons,
the installer exits after trying to put up the dropped connection dialog, which
is supposed to actually wait for the user to hit "cancel" or "resume".

This is probably caused by or at least made worse by the patch from bug 160973.

Comment 1

[Andrew Schultz]

Attachment: patch

this patch calls gtk_main on pause and gtk_main_quit on cancel or restore
this removes the bInstallClicked.  it doesn't seem to do anything but screw up
DLResume.

Also, the need to call gtk_main_quit in DLCancel has nothing to do with auto
mode.

Comment 2

[Andrew Schultz]

Attachment: patch v2

this is the right patch.
I need some sleep.

Comment 3

[Andrew Schultz]

nobody noticed this in 1.7a, but it seems like a serious regession that would
frustrate users who encountered it.

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 143948 [details] [diff] [review]
patch v2

looks ok, I assume you've checked that the gtk_main/gtk_main_quit()s match up
in both the auto and non-auto install cases.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 143948 [details] [diff] [review]
patch v2

r=dveditz

Comment 6

[Andrew Schultz]

Comment on attachment 143948 [details] [diff] [review]
patch v2

this prevents the installer from exitting when pressing "pause".

Comment 7

[chris hofmann]

Comment on attachment 143948 [details] [diff] [review]
patch v2

a=chofmann for 1.7 -- wait until later today to check in.

Comment 8

[Andrew Schultz]

fix checked in by Neil.

for the record, I retested the installer before bug 160973, and it had similar
problems to this bug, but they were confined to auto mode.