Closed
Bug 242441
Opened 20 years ago
Closed 20 years ago
Port fix to bug 242082 to SeaMonkey
Categories
(SeaMonkey :: Help Documentation, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(2 files)
6.39 KB,
patch
|
rjkeller
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
5.59 KB,
patch
|
caillon
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
In an effort to narrow down the cause of bug 242082 I eventually came up with this patch, only to discover Jan had written an almost identical patch to bug 242082, but unfortunately my bugmail was not working in the interim :-(
Assignee | ||
Comment 1•20 years ago
|
||
This patch contains one slight difference to Jan's patch in that it uses instanceof which is preferred instead of try/catch and QueryInterface.
Assignee: rlk → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Assignee | ||
Updated•20 years ago
|
Attachment #147552 -
Flags: review?(rlk)
Comment 2•20 years ago
|
||
Comment on attachment 147552 [details] [diff] [review] Proposed patch looks good! r=rlk@trfenv.com. Thanks for this patch, Neil! Let's checkin ASAP.
Attachment #147552 -
Flags: review?(rlk) → review+
Assignee | ||
Updated•20 years ago
|
Attachment #147552 -
Flags: superreview?(roc)
Attachment #147552 -
Flags: superreview?(roc) → superreview+
Assignee | ||
Comment 3•20 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•20 years ago
|
||
Oops, I copied Jan's bug - help clears when you select an index letter.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•20 years ago
|
||
The issue I originally wanted to fix was that clicking on "A" in help index clears the help viewer. But I've also included a fix to focus the search field when you hit Alt+S ;-)
Assignee | ||
Updated•20 years ago
|
Attachment #148964 -
Flags: review?(rlk)
Comment 6•20 years ago
|
||
Comment on attachment 148964 [details] [diff] [review] Fix issues Neil, I'm going to ask caillon to review this. You're adding code which uses classes/interfaces that I am not familiar with.
Attachment #148964 -
Flags: review?(rlk) → review?(caillon)
Comment 7•20 years ago
|
||
Comment on attachment 148964 [details] [diff] [review] Fix issues Looks reasonable. r=caillon.
Attachment #148964 -
Flags: review?(caillon) → review+
Assignee | ||
Updated•20 years ago
|
Attachment #148964 -
Flags: superreview?(alecf)
Comment 8•20 years ago
|
||
Comment on attachment 148964 [details] [diff] [review] Fix issues sr=alecf
Attachment #148964 -
Flags: superreview?(alecf) → superreview+
Assignee | ||
Comment 9•20 years ago
|
||
Checked in.
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•