242441 - Port fix to bug 242082 to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[[e-mail]]

In an effort to narrow down the cause of bug 242082 I eventually came up with
this patch, only to discover Jan had written an almost identical patch to bug
242082, but unfortunately my bugmail was not working in the interim :-(

Comment 1

[[e-mail]]

Attachment: Proposed patch

This patch contains one slight difference to Jan's patch in that it uses
instanceof which is preferred instead of try/catch and QueryInterface.

Comment 2

[R.J. Keller]

Comment on attachment 147552 [details] [diff] [review]
Proposed patch

looks good! r=[e-mail].

Thanks for this patch, Neil! Let's checkin ASAP.

Comment 3

[[e-mail]]

Fix checked in.

Comment 4

[[e-mail]]

Oops, I copied Jan's bug - help clears when you select an index letter.

Comment 5

[[e-mail]]

Attachment: Fix issues

The issue I originally wanted to fix was that clicking on "A" in help index
clears the help viewer. But I've also included a fix to focus the search field
when you hit Alt+S ;-)

Comment 6

[R.J. Keller]

Comment on attachment 148964 [details] [diff] [review]
Fix issues

Neil, I'm going to ask caillon to review this. You're adding code which uses
classes/interfaces that I am not familiar with.

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 148964 [details] [diff] [review]
Fix issues

Looks reasonable.  r=caillon.

Comment 8

[Alec Flett]

Comment on attachment 148964 [details] [diff] [review]
Fix issues

sr=alecf

Comment 9

[[e-mail]]

Checked in.