242704 - AIX debug build fails after recent AppendInt changes

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Philip K. Warren]

AIX debug builds fail to build after the recent changes to AppendInt. The error
occurs when compiling nsContentTestNode.cpp. I will attach a build log from a
recent build.

Comment 1

[Philip K. Warren]

Attachment: Failing build log

Comment 2

[Philip K. Warren]

Attachment: Patch v1

Comment 3

[Philip K. Warren]

Comment on attachment 147743 [details] [diff] [review]
Patch v1

I used the initial suggestion from Brendan in
http://bugzilla.mozilla.org/show_bug.cgi?id=133801#c6.

Comment 4

[Darin Fisher]

I guess this is caused by the fact that we now have an AppendInt that takes a
PRUint32 as well as the one that takes a PRInt32, and NS_PTR_TO_INT32 doesn't
include a cast to specify the INT32 type.

Comment 5

[Darin Fisher]

Comment on attachment 147743 [details] [diff] [review]
Patch v1

sr=darin

requesting MOA=/r= from jst.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 147743 [details] [diff] [review]
Patch v1

     aResult.Append(PRUnichar('@'));
-    aResult.AppendInt(NS_PTR_TO_INT32(aContent), 16);
+    AppendASCIItoUTF16(nsPrintfCString("%p", aContent), aResult);

Wanna remove the first Append call, and make the format string to
nsPrintfCString be "@%p"?

r=jst

Comment 7

[Darin Fisher]

hmm... i was just reminded of the fact that nsPrintfCString uses a 16 byte
buffer by default.  it uses PR_vsnprintf to write to that buffer, which means
that a 64-bit address in hex will not entirely fit in the buffer.  with the '@'
character added, that means the address will be truncated to 14 hex characters.
 you can also use the other form of the nsPrintfCString constructor:

  nsPrintfCString(18, "@%p", aContent)

this causes an 18 character, malloc'd buffer to be used instead.

Comment 8

[Philip K. Warren]

Attachment: Patch v2

Patch that was checked in.

Comment 9

[Darin Fisher]

Comment on attachment 147751 [details] [diff] [review]
Patch v2

sr=darin

Comment 10

[Philip K. Warren]

Fix checked in.

Checking in nsContentTestNode.cpp;
/cvsroot/mozilla/content/xul/templates/src/nsContentTestNode.cpp,v  <-- 
nsContentTestNode.cpp
new revision: 1.16; previous revision: 1.15
done

Comment 11

[Philip K. Warren]

Comment on attachment 147751 [details] [diff] [review]
Patch v2

Requesting approval for a simple build break fix, which only affects debug
builds.

Comment 12

[Mike Kaply [:mkaply]]

Comment on attachment 147751 [details] [diff] [review]
Patch v2

a=mkaply

Comment 13

[Philip K. Warren]

Checked into 1.7 branch.

Checking in nsContentTestNode.cpp;
/cvsroot/mozilla/content/xul/templates/src/nsContentTestNode.cpp,v  <-- 
nsContentTestNode.cpp
new revision: 1.14.14.1; previous revision: 1.14
done