243019 - [FIX]"Wrong parent style context" warnings in profile wizard

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

This is a gtk2+xft build from current cvs trunk (seamonkey).

When creating a new profile, I Get these warnings:
frame: DocElementBox(wizard)(-1) (0x8424f18) style: 0x8424e98 {}
Has parent context:  style: 0x8424cb8 :-moz-canvas {}
Should be null
 
frame: DocElementBox(wizard)(-1) (0x8424f18) style: 0x8424e98 {}
Has parent context:  style: 0x8424cb8 :-moz-canvas {}
Should be null
 
frame: DocElementBox(wizard)(-1) (0x8424f18) style: 0x8424e98 {}
Has parent context:  style: 0x8424cb8 :-moz-canvas {}
Should be null
 
frame: DocElementBox(wizard)(-1) (0x8424f18) style: 0x8424e98 {}
Has parent context:  style: 0x8424cb8 :-moz-canvas {}
Should be null
 
frame: DocElementBox(wizard)(-1) (0x8424f18) style: 0x8424e98 {}
Has parent context:  style: 0x8424cb8 :-moz-canvas {}
Should be null
 
frame: DocElementBox(wizard)(-1) (0x8424f18) style: 0x8424e98 {}
Has parent context:  style: 0x8424cb8 :-moz-canvas {}
Should be null
 
frame: DocElementBox(wizard)(-1) (0x8424f18) style: 0x8424e98 {}
Has parent context:  style: 0x8424cb8 :-moz-canvas {}
Should be null
 
frame: DocElementBox(wizard)(-1) (0x8424f18) style: 0x8424e98 {}
Has parent context:  style: 0x8424cb8 :-moz-canvas {}
Should be null


I believe I got one of those per page of the wizard, but I'm not sure about that.

my mozconfig:
ac_add_options --enable-crypto
ac_add_options --enable-default-toolkit=gtk2
ac_add_options --enable-xft
 
ac_add_options --disable-optimize
ac_add_options --enable-debug

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

actually, just clicking "create profile" lead to 3 or 4 of those warnings

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

The patch in bug 236921 missed the case when the root has an XBL binding with
scoped sheets attached to it.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

would this patch also fix a similar warning, just for dialog instead of wizard?
(happened when clicking "delete profile", I think)

Comment 4

[Boris Zbarsky [:bzbarsky]]

It should, yes.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #4)
> It should, yes.

and it indeed does.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed.