Closed Bug 243091 Opened 20 years ago Closed 20 years ago

Don't distribute communicator/navigator/mailnews/editor cruft in classic.jar/comm.jar

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bugs, Assigned: bugs)

References

Details

Attachments

(2 files, 1 obsolete file)

When we build in xpfe/communicator, xpfe/components and themes/classic we
inadvertedly package a bunch of stuff we don't need, adding at least 300KB
compressed to the download size.

Almost none of this is required by our app, so here's a patch to turn it all
off. If we discover any problems they can be identified and fixed.
what do we still need/use in comm.jar period?
At this point:
- profile manager UI (going away)
- cookie stuff (this needs some cleanup - we basically only use
cookieAcceptDialog.* I think - the rest is seamonkey-only UI) 
- and some other poorly packaged layout resources (xml pretty print, etc) that
should be going into global (toolkit.jar) not communicator. 

The first patch I attached doesn't actually run in a clean build since it
doesn't register communicator skin and requires some build tweaking in
xpfe/components/build .. new one coming up. 
Status: NEW → ASSIGNED
Attached patch one that runsSplinter Review
Attachment #148035 - Attachment is obsolete: true
*** Bug 189043 has been marked as a duplicate of this bug. ***
Blocks: 171082
Possible regrssions caused by this bug:
Bug 243386, Bug 243482, Bug 243387, Bug 243390
Wheee, there goes ChatZilla too. *sigh*
Will any of this paring down be selectively applied to
AVIARY_1_0_20040515_BRANCH?  I know it's caused a ton of breakage of legacy
extensions and various other miscellaneous things as mentioned above, but
clearly some of the changes are for the better with absolutely no known adverse
side effects.  The much smaller size is one of the things Firefox needs to
convert users, especially the dialup users.  I personally don't expect any of
this change will be applied to the branch for stability's sake, but perhaps once
some of the regressions are fixed at least parts of this paring might be ported
to the 0.9/1.0 branch.
These changes are already on the aviary branch, they were part of Ben's checkin
from 2004-05-16 11:16:
http://bonsai.mozilla.org/cvsgraph.cgi?file=mozilla/browser/extensions/package-fixup/jar.mn
(In reply to comment #9)
> These changes are already on the aviary branch

Oops, sorry about that (and for the bugspam)!  I really should have checked
first before assuming they hadn't entered the branch.
branch and trunk fixed.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
This is just a rough example of what changed in Ben's checkin of all this.
You need to log in before you can comment on or make changes to this bug.