243482 - Input type=file, no display of any 'browse...' button, widget not functional

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[philippe (part-time)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7b) Gecko/20040421
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040512 Firefox/0.8.0+

Using [Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a)
Gecko/20040512 Firefox/0.8.0+]
Try to use the Validate by File Upload field in above mentioned form. On Firefox
(since 20040510 ?) the file upload filed  downs't display the text (expected
'browse...' ) on the button, and clicking the button doesn't do nothing.

Reproducible: Always
Steps to Reproduce:
1.Go to http://validator.w3.org/
2.try to upload file for validation, click on the button
3.nothing happens

Actual Results:  
The button should display some text ('browse...'), clicking on the button should
open a sheet to navigate to a file and allow the user to select a file on the
local file system.

Expected Results:  
display some text (label) on the button, and allow the user to upload a file

Comment 1

[philippe (part-time)]

Attachment: showin the file upload field on the mentioned URL

The red block points to the broken button.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Worksforme on Linux (build from May 12 as well)... any chance of narrowing down
the day this broke?

Comment 3

[philippe (part-time)]

(In reply to comment #2)
> ... any chance of narrowing down
> the day this broke?

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040506
Firefox/0.8.0+

Works fine

But
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040510
Firefox/0.8.0+
is broken.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Are there any builds in that range you could check?  About 8000 lines of code
changed in those 5 days, in 3 dozen separate checkins or so.... :(

Comment 5

[philippe (part-time)]

(In reply to comment #4)
> Are there any builds in that range you could check?  About 8000 lines of code
> changed in those 5 days, in 3 dozen separate checkins or so.... :(

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040508
Firefox/0.8.0+

Works fine. Apparently no OS X builds on 0509.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Is this a problem in SeaMonkey builds?  Or just Firefox?

I don't see any changes to core gecko code that woul really affect this, and
there was a whole slew of major changes to Firefox (eg bug 243091 looks pretty
suspicious to me...)

Comment 7

[philippe (part-time)]

[update] It is not only the input type=file. Any submit button breaks. 

I just attempted to update my blog. No way to submit a post (input type=submit).
Or changing the display of the comments on http://www.macosxhints.com/ from
threaded to anything else (a submit button with a POST attached) doesn't work
either.

Comment 8

[philippe (part-time)]

(In reply to comment #6)
> Is this a problem in SeaMonkey builds?  Or just Firefox?
> 

I'm testing with Firefox (OS X) here. (and using Mozilla 1.7 RC1 to submit to
bugzilla).

Comment 9

[Boris Zbarsky [:bzbarsky]]

(In reply to comment #8)
> I'm testing with Firefox (OS X) here. (and using Mozilla 1.7 RC1 to submit to
> bugzilla).

Yes, I realize that... ;)  Could you try a May 11 or later SeaMonkey nightly?

Note that I just tried a Linux firefox nightly (from May 12) and the browse
button appears there...

Comment 10

[philippe (part-time)]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040512

Works fine

Comment 11

[Boris Zbarsky [:bzbarsky]]

OK, then this is firefox-specific.  Reassigning accordingly.

Upping severity, since this is pretty basic functionality to have broken...

Comment 12

[Boris Zbarsky [:bzbarsky]]

Ben, see comment 6.  This looks like Firefox-only and Mac-only....

Comment 13

[Žiga Sancin]

Works fine on Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a)
Gecko/20040512 Firefox/0.8.0+

Comment 14

[Boris Zbarsky [:bzbarsky]]

*** Bug 243884 has been marked as a duplicate of this bug. ***

Comment 15

[Asaf Romano (gone)]

any progress here?

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

layout should not depend on communicator for this file

Comment 17

[Ben Goodger (use ben at mozilla dot org for email)]

Hm, I don't see this on the branch, but I can understand why it might have
broken (see patch). I haven't tested this yet. Am pulling a trunk tree now on my
mac to test. 

In general nothing in gecko should depend on resources in communicator
especially... I'm slightly uncomfortable about making them depend on global too
but that seems to be fairly widespread. I think a tree-wide patch to create a
"gecko" resources package would be a good idea. 

Comment 18

[Ben Goodger (use ben at mozilla dot org for email)]

Ignore the patch. This was fixed by reordering the makefiles so that
communicator resources are packaged before the .app file is rsync'ed. I'll file
a bug at some future point about repackaging all gecko resources into its own
chrome registry bundle, rather than relying on obsolete seamonkey terminology. 

Comment 19

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed, branch and trunk.