Closed
Bug 244080
Opened 21 years ago
Closed 21 years ago
Compiler warning in mozilla/extensions/cookie/nsPermissionManager.cpp
Categories
(Core :: Graphics: Image Blocking, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: tenthumbs, Assigned: security-bugs)
Details
Attachments
(1 file)
|
735 bytes,
patch
|
mvl
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
Gcc says:
nsPermissionManager.cpp:667:
warning: comparison of unsigned expression < 0 is always false
and the code is:
PRUint32 type = GetTypeIndex(lineArray[1]->get(), PR_TRUE);
if (type < 0)
continue;
Gcc eliminates the continue line which isn't good. This happened in the fix for
bug 219752. CC'ing the author. Fix upcoming.
|
||
Updated•21 years ago
|
Attachment #148872 -
Flags: review?(mvl)
|
||
Updated•21 years ago
|
Attachment #148872 -
Flags: review?(mvl) → review+
|
|
||
Comment 2•21 years ago
|
||
mvl, can you drive this in, please?
|
|
||
Updated•21 years ago
|
Attachment #148872 -
Flags: superreview?(darin)
|
||
Updated•21 years ago
|
Attachment #148872 -
Flags: superreview?(darin) → superreview+
|
|
||
Comment 3•21 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•