246035 - Theme icons missing in Open/Save dialogs

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect, P3)

Description

[Steven Garrity [:sgarrity]]

The "Create a new folder" and "Move up a folder" buttons are missing their icons
in the Gnome open/save dialogs. The buttons are just blank. See attached
screeenshot.

Comment 1

[Steven Garrity [:sgarrity]]

Attachment: Screenshot of Gnome open dialog with missing button images

Comment 2

[Mike Connor [:mconnor]]

*grumble grumble grumble* I may get a chance to look at this later, I hopefully
will.

Comment 3

[Erich 'Ricky' Iseli]

Same happening with KDE.

Comment 4

[Mike Connor [:mconnor]]

*** Bug 246006 has been marked as a duplicate of this bug. ***

Comment 5

[Marek Stępień [:marcoos, inactive]]

This is not Gnome's filepicker.

Mozilla has its own filepicker for Linux (mainly because of the fact that the
previous Gnome file picker used to suck a lot ;))

So this is not "OS Integration" issue. It's a problem with an incomplete theme
being pushed for 0.9, I don't know which component would be good for this bug,
though.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed. I made this artwork myself based on other pieces so it's a little rough.
I'm not too concerned since we'll eventually use GNOME's file picker. 

Comment 7

[Ali Ebrahim]

*** Bug 246109 has been marked as a duplicate of this bug. ***

Comment 8

[Ali Ebrahim]

*** Bug 246442 has been marked as a duplicate of this bug. ***

Comment 9

[Lionfire]

Looks to be mostly working in 0.9, but the save dialog has a very odd image for
"new directory" -- it seems to be the "up level" and "home" images next to each
other, rather than a normal image.

Comment 10

[Marek Stępień [:marcoos, inactive]]

The 'create directory' button has a wrong icon (it's the same as for "go up"),
also another home icon is displayed on the right side of it.

Comment 11

[Marek Stępień [:marcoos, inactive]]

Attachment: "Save as" dialog with a broken 'Create new directory' button

The 'create new directory button' is the one in the top-right corner.

Comment 12

[PikeUK]

*** Bug 246749 has been marked as a duplicate of this bug. ***

Comment 13

[Zibi Braniecki [:zbraniecki][:gandalf]]

*** Bug 246803 has been marked as a duplicate of this bug. ***

Comment 14

[Tuukka Tolvanen (sp3000)]

*** Bug 247071 has been marked as a duplicate of this bug. ***

Comment 15

[Christian 'CeeJay' Jensen]

Should it be changed from blocking 0.9 to blocking 1.0 since 0.9 have already
been released ?

Comment 16

[Bill Mason]

*** Bug 247584 has been marked as a duplicate of this bug. ***

Comment 17

[Bill Mason]

*** Bug 248079 has been marked as a duplicate of this bug. ***

Comment 18

[PikeUK]

*** Bug 248110 has been marked as a duplicate of this bug. ***

Comment 19

[Zibi Braniecki [:zbraniecki][:gandalf]]

please. fix it for 0.9.1... It's really important for marketing the browser not
to have such bugs...

Comment 20

[Marek Stępień [:marcoos, inactive]]

If the GTK/Gnome file chooser isn't going to be used in 1.0, this bug should be
a blocker for 1.0.

Adding Kevin Gerich as CC, requesting blocking-aviary1.0 flag.

Comment 21

[Stephen Horlander [:shorlander]]

Isn't this the same thing as http://bugzilla.mozilla.org/show_bug.cgi?id=250171

That bug has been fixed, can anyone verify if this is still a problem.

Comment 22

[Steven Garrity [:sgarrity]]

I downloaded the latest nightly
(http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/
firefox-i686-linux-gtk2+xft.tar.gz - 19-Aug-2004 15:25) and it's using the Gnome
open/save dialogs (which is awesome), rendering this bug obsolete.

Can anyone confirm if these Gnome dialogs will be in 1.0 (PR, RC, etc.)? If so,
this but is obsolete (and Firefox is that much better on Gnome).

Comment 23

[Carlos Rodrigues]

Well, in 0.9.3 the "open" dialog looks fine but the "save" dialog still has the
problem.

Comment 24

[Stephen Horlander [:shorlander]]

(In reply to comment #23)
> Well, in 0.9.3 the "open" dialog looks fine but the "save" dialog still has the
> problem.

Could I get a screenshot? It looks fine on my GTK build.

Also, as far as I can tell the branch is still using the custom file selector.

Comment 25

[Carlos Rodrigues]

No point in attaching a new screenshot, it looks exactly like this:
http://bugzilla.mozilla.org/attachment.cgi?id=150804&action=view

Comment 26

[Stephen Horlander [:shorlander]]

(In reply to comment #25)
> No point in attaching a new screenshot, it looks exactly like this:
> http://bugzilla.mozilla.org/attachment.cgi?id=150804&action=view

Since they made 0.9.3 from the 0.9.1 branch, the changes didn't make it in. It
is fixed in the nightlies.

Comment 27

[timeless]

fwiw those dialogs are only used if you have a new enough version of gnome. so
this bug will not be obsoleted by that change.

Comment 28

[Mike Connor [:mconnor]]

Fixed after the 0.9.x minibranch, re-resolving.