250898 - XPInstall Whitelist UI: Clicking on Edit Settings opens one dialog per browser window

Status: RESOLVED FIXED

(Firefox :: General, defect, P3)

Description

[PikeUK]

When clicking "Edit Settings..." in the XPInstall blocked software message bar
one permissions dialog opens for each browser window currently open.

Steps to reproduce:
1. Open three browser windows.
2. Visit a un-whitelisted site with an XPI link e.g.
http://www.hacksrus.com/~ginda/chatzilla/
3. Click XPI link.

Expected results:
One "Allowed Sites" permissions dialog opens

Actual results:
Three "Allowed Sites" permissions dialogs open (or maybe one dialog is opened
three times, either way you have to click OK/Cancel three times before it goes
away).

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Comment 2

[PikeUK]

I'm not sure the patch worked, I'm still seeing this problem in:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040712
Firefox/0.9.1+

Anyone else?

Comment 3

[Asa Dotzler [:asa]]

This is not fixed. I've just tested this. Visit a page with three browser
windows open. Click on the extension to trigger the Software Installation
Warning toolbar. Click the Edit Options button. Click cancel in the resulting
Allowed Sites window. Note that your second Firefox browser window will be
focused and a second allowed sites dialog is raised. Cancel that second dialog
and your third Firefox window will be focused with a third Allowed Sites dialog.

I've tested repeatedly with a current branch nightly build (7/14)on Windows XP.

Comment 4

[Asa Dotzler [:asa]]

(additional note, it's not just cancel that causes this. The three allowed sites
dialogs are created regardless of how you dismiss them.)

Comment 5

[Jesse Ruderman]

*** Bug 253165 has been marked as a duplicate of this bug. ***

Comment 6

[Bart Libert]

*** Bug 254421 has been marked as a duplicate of this bug. ***

Comment 7

[chris hofmann]

who can review?  is this ready to go?

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch, fixes this bug and 255162

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed branch. 

Comment 10

[Daniel Veditz [:dveditz]]

Fixed on trunk (aviary branch landing, I presume).