251846 - About:, Help->About, Help->Release Notes and about:config are broken

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P2)

Description

[Frederic Bezies]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040717 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040717 Firefox/0.9.1+

Simple to see. I built firefox from aviary cvs code, up to date at 23:30
(mozilla.org time).

After it starts, Firefox asked me if I want to get firefox has default browser.
I answered yes. After this, I go to Help / About Firefox and I get this xul error :

         <label id="version" value="&aboutVersion;"/>
---------^

I tried about: and I get this xul error :

<a id="mozlink" href="&releaseURL;">&brandShortName; &version;</a>
----------------------^

This is annoying :[

Reproducible: Always
Steps to Reproduce:
1.See details.
Actual Results:  
Big bad xul errors.

Expected Results:  
Displays version info and about dialog box.

Using fedora Core 2.

Here is my .mozconfig :

. $topsrcdir/browser/config/mozconfig

ac_add_options --disable-tests
ac_add_options --disable-debug

ac_add_options --enable-optimize='-O3 -freorder-blocks -march=pentium4 -msse2
-fomit-frame-pointer -fforce-addr' 

ac_add_options --disable-shared
ac_add_options --enable-static

ac_add_options --disable-pedantic

ac_add_options --enable-default-toolkit=gtk2
ac_add_options --enable-xft
ac_add_options --disable-freetype2

Comment 1

[Sekundes]

And Help -> Release Notes redirects to http://www.mozilla.org/releases/ which is 
for Mozilla but not Firefox.

Comment 2

[Steffen Wilberg]

The reason is that the version string in brand.dtd isn't expanded anymore.

1. Download a zip build from
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/BEAST/
2. Look into chrome/en-US.jar, view brand.dtd.
It displays:
<!ENTITY  version               >

If I hardcode "0.9.1+" there, these issues are fixed.

This is a regression from bsmedberg's checkin from 2004-07-16 12:57-12:58.

Comment 3

[Bill Mason]

*** Bug 251900 has been marked as a duplicate of this bug. ***

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

I get a similar but different error; doing about:config gives:

  <menuitem label="&copyName.label;" accesskey="&copyName.accesskey;"
oncommand="copyName();"/>
-------------------^

however, en-US.jar has the entity defined correctly in both
locale/global/config.dtd and locale/en-US/global/config.dtd.

Comment 5

[Peter van der Woude [:Peter6]]

Win32 installerbuilds get
Installer chokes for me. "Error occured during installation - US Region Pack:
-208 INVALID_ARGUMENTS"  and simply won't launch

Comment 6

[Peter van der Woude [:Peter6]]

about:config shows a blank screen with the following text
<menuitem label="&copyName.label;" accesskey="&copyName.accesskey;"
oncommand="copyName();"/>
-------------------^

Comment 7

[Lukas Petrovicky (CZilla)]

also download manager in FF 20040717 gives me this:

label="&cmd.options.label;" accesskey="&cmd.options.accesskey;"
---------------------^

Comment 8

[u60234]

*** Bug 251982 has been marked as a duplicate of this bug. ***

Comment 9

[u60234]

I think the problem with about:config is the "#" in front of the licens and the
comments in config.dtd. Dtd files usually have "<!-- comment -->. This file have
had "#" for a long time, but I think they were stripped out by the preprocessor.  

Comment 10

[Benjamin Smedberg]

I just checked in a change for about:config

I believe I fixed brand.dtd yesterday.

Some installer issues are still outstanding, and I may not be able to get to
them until Monday (I'm getting rid of the US.jar region pack, folding those
files into the en-US.jar langpack).

Comment 11

[Frederic Bezies]

With your patch added on 2004-07-18 05:59, in a build I made thirty minutes ago
about:config is repaired, but both about: and help / about firefox are always
broken.

Xul errors are the same as in description.

Comment 12

[Altuhov Dmitriy]

In build 2004/07/18 it was fixed!

Comment 13

[Thomas Rutter]

I have build 20040718 (installer) and I'm still experiencing the problem with
about: and Help->About Mozilla Firefox, although the Help->Release Notes is fixed.

My UA string:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040718
Firefox/0.9.1+

Comment 14

[Frederic Bezies]

After last changes on aviary branch, it is now impossible to get a working
window in firefox :[

I built firefox with a blank new aviary branch source checked out and up-to-date
at 22:00 18 july 2004 (mozilla.org time) and get a little xul error window,
saying this :

<window id="main-window"
^

Comment 15

[Steffen Wilberg]

Frederic, that's bug 252063.

Comment 16

[Frederic Bezies]

Some news :

1) bug #252063 is now dead
2) this bug can be closed as fixed too, because both about: and help / about are
working again.

My User-Agent : Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040719
Firefox/0.9.1+

Note : 10 minutes old Aviary based build.

Comment 17

[Steffen Wilberg]

About:, Help->About and Help->Release Notes are indeed fixed.
But about:config is still broken.

Comment 18

[Steffen Wilberg]

Sorry, that was just me having the remains of a patch in my tree.
-> fixed.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040719
Firefox/0.9.1+ (Steffen)

Comment 19

[Steffen Wilberg]

*** Bug 252112 has been marked as a duplicate of this bug. ***

Comment 20

[sairuh (rarely reading bugmail)]

vrfy's fixed using aviary1.0 (branch) builds on win xp and linux rh9 (7/21
bits), and mac os x 10.3.4 (7/20 bits).