256072 - Dragging links from the URL bar to the bookmarks menu should add the link to bookmarks.

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Pavel Penaz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040818 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040818 Firefox/0.9.1+

In recent branch builds dragging a link from URL bar does not add the link to
bookmarks.

Reproducible: Always
Steps to Reproduce:
1. Go to ie. www.google.com
2. Drag the link from the URL bar to the bookmarks menu


Actual Results:  
The link is not added to bookmarks.

Expected Results:  
The link should have been added to bookmarks.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: proxyicon-copy-on-drag-0.patch

The proxy icon dnd handler wasn't setting COPY as the drag type, so the dnd
receiver was trying to do a move -- and bailing because the "source" of the
move was invalid.  This fixes the proxy icon, but there's still a bug where
drags of links from the content area do the same thing, and I'm having a hard
time tracking down where the drag begins there.  nsContentAreaDragAndDrop sets
all of COPY/LINK/MOVE, so it's not that..

Comment 2

[José Jeria]

*** Bug 256089 has been marked as a duplicate of this bug. ***

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 156466 [details] [diff] [review]
proxyicon-copy-on-drag-0.patch

a=[e-mail]

Comment 4

[José Jeria]

*** Bug 256159 has been marked as a duplicate of this bug. ***

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

in.

Comment 6

[PikeUK]

I can now drag the icon to the bookmarks toolbar and the bookmarks menu, but
dragging to the bookmarks sidebar still doesn't work (it shows the no-target
cursor).

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040819
Firefox/0.9.1+

Comment 7

[Jesse Ruderman]

I think this patch caused bug 256357.

Comment 8

[amano]

Does this bug cover dragging Links to the Bookmarks Sidebar as well? (because
that still doesn't work for me on Mozilla/5.0 (Windows; U; Windows NT 5.1;
en-US; rv:1.7.2) Gecko/20040822 Firefox/0.9.1+) or is there another bug covering
this?

If not we should file a bug because this is a major regression from 0.9.3 and
will affect all those with the Bookmarks Sidebar permanently open.

Comment 9

[Worcester12345]

(In reply to comment #6)
> I can now drag the icon to the bookmarks toolbar and the bookmarks menu, but
> dragging to the bookmarks sidebar still doesn't work (it shows the no-target
> cursor).
> 
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040819
> Firefox/0.9.1+

(In reply to comment #7)
> I think this patch caused bug 256357.


Should this be reopened for these two, or at least the first one? If not, do you
have a new bug, Pikey? Thanks.

Comment 10

[Doug Wright]

Dragging the *icon* seems to work, but I always dragged the actual *address*
(didn't know about icon!).

Dragging the address still doesn't work.

This bug needs to be reopened

Comment 11

[Ian]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.2) Gecko/20040823
Firefox/0.9.1+

Dragging links to bookmarks toolbar isn't fixed on Mac.

Comment 12

[Tracy Walker [:tracy]]

verified with Firefox Branch 2004-09-10-08-0.9  Mac and Windows works

Comment 13

[Worcester12345]

fixed-aviary1.0 keyword?

Comment 14

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change