277656 - Update nsFontMetricsXft in Cairo

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[Jungshik Shin]

There are a couple of changes to gtk/nsFontMetricsXft.cpp that haven't been
ported to cairo/nsFontMetricsXft.cpp. Among them are dbaron's fix for 'bad'
fonts and moving  of some utility functions to shared/nsFontConfigUtils.

Comment 1

[Takeshi Kurosawa :takenspc]

*** Bug 277659 has been marked as a duplicate of this bug. ***

Comment 2

[Jungshik Shin]

Attachment: patch

Now that cairo build error was fixed, I made a patch porting all the changes
made in gtk/nsFontMetricsXft* (since the fork) to cairo-xft.

Comment 3

[Jungshik Shin]

Comment on attachment 182233 [details] [diff] [review]
patch

asking for r/sr
this part of cairo-build went fine although it failed in content/.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

In general we need to figure out how to integrate our font code with the
emerging Cairo font API.

Comment 5

[Jungshik Shin]

(In reply to comment #4)
> In general we need to figure out how to integrate our font code with the
> emerging Cairo font API.

I have no doubt about that, but I'm not sure what you meant by that in the
context of this bug. Did you mean that it's not worth making nsFontMetricsXft in
cairo up to date with the one in gtk2 because it's gonna change drastically in
the near future?

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 182233 [details] [diff] [review]
patch

It's worth keeping them in sync. I just wanted to make sure you don't do tons
of work to get this working really well before we change it drastically :-)

Comment 7

[Jungshik Shin]

Comment on attachment 182233 [details] [diff] [review]
patch

Thanks for sr and clarification.

asking for a to trunk. this patch is for non-default cairo build so that it's
not critical to get this in before 1.8b2/1.1a. (provided that cairo wouldn't
have its heyday in 1.1). 

On the other hand, this patch is just porting changes made in gtk/xft to
cairo/xft and little 'deliberation' by driver is necessary :-)

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 182233 [details] [diff] [review]
patch

Most other checkins to gfx/src/cairo/ these days have been without approval,
which is fine, since it's not part of anything that's going to be relevant for
1.8/a1.1.

Comment 9

[Jungshik Shin]

landed on the trunk
thanks for quick a and sorry for bothering you with unnecessary req.