277659 - build failure: --enable-default-toolkit=cairo-gtk2

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[Takeshi Kurosawa :takenspc]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a6) Gecko/20050108 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a6) Gecko/20050108 Firefox/1.0+

I tried to build firefox with toolkit=cairo-gtk2 from cvs. But I couldn't build it.


Reproducible: Always

Steps to Reproduce:
1.Get source from CVS
2.make
3.

Actual Results:  
The following error messages were displayed.

c++ -o nsCairoDeviceContext.o -c  -DOSTYPE=\"Linux2.6\" -DOSARCH=\"Linux\"
-DHAVE_DEPENDENT_LIBS -I./. -I./.. -I./../shared  -I../../../dist/include/xpcom
-I../../../dist/include/string -I../../../dist/include/gfx
-I../../../dist/include/widget -I../../../dist/include/intl
-I../../../dist/include/view -I../../../dist/include/pref
-I../../../dist/include/uconv -I../../../dist/include/unicharutil
-I../../../dist/include/locale -I../../../dist/include/necko
-I../../../dist/include/content -I../../../dist/include/layout
-I../../../dist/include/dom -I../../../dist/include/debug
-I../../../dist/include/imglib2 -I../../../dist/include/zlib
-I../../../dist/include/gfx -I../../../dist/include
-I/home/taken/src/firefox/mozilla/dist/include/nspr     -I. -I/usr/X11R6/include
  -fPIC  -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion
-Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy
-Wno-non-virtual-dtor -Wno-long-long -pedantic -fshort-wchar -pthread -pipe 
-DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions -gstabs+ 
-I/usr/include/freetype2 -I/usr/X11R6/include   -DXTHREADS
-I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include
-I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -DMOZ_ENABLE_GTK2
-DMOZ_ENABLE_XFT  -I/usr/X11R6/include -DMOZILLA_CLIENT -include
../../../mozilla-config.h -Wp,-MD,.deps/nsCairoDeviceContext.pp
nsCairoDeviceContext.cpp
nsCairoDeviceContext.cpp: In member function `virtual nsresult
   nsCairoDeviceContext::CreateRenderingContextInstance(nsIRenderingContext*&)
   ':
nsCairoDeviceContext.cpp:233: error: cannot allocate an object of type `
   nsCairoRenderingContext'
nsCairoDeviceContext.cpp:233: error:   because the following virtual functions
   are abstract:
../../../dist/include/gfx/nsIRenderingContext.h:795: error:     virtual nsresult
   nsIRenderingContext::RenderEPS(const nsRect&, FILE*)
nsCairoDeviceContext.cpp: In function `void
   xlfd_from_pango_font_description(GtkWidget*, const PangoFontDescription*,
   nsString&)':
nsCairoDeviceContext.cpp:940: warning: unused variable `char*tmp'
gmake[5]: *** [nsCairoDeviceContext.o] Error 1
gmake[5]: Leaving directory `/home/taken/src/firefox/mozilla/gfx/src/cairo'
gmake[4]: *** [libs] Error 2
gmake[4]: Leaving directory `/home/taken/src/firefox/mozilla/gfx/src'
gmake[3]: *** [libs] Error 2
gmake[3]: Leaving directory `/home/taken/src/firefox/mozilla/gfx'
gmake[2]: *** [tier_9] Error 2
gmake[2]: Leaving directory `/home/taken/src/firefox/mozilla'
gmake[1]: *** [default] Error 2
gmake[1]: Leaving directory `/home/taken/src/firefox/mozilla'
gmake: *** [build] Error 2


Build environment

Debian GNU/Linux testing/unstable
kernel 2.6.9
GCC 3.3.5
glib 2.4.8-1
cairo 0.2.0 (http://cairographics.org/packages/debian/)
gtk2 2.4.14-2 

.mozconfig

mk_add_options MOZ_CO_PROJECT=browser
ac_add_options --enable-application=browser
ac_add_options --enable-extensions=default,irc,tasks,gnomevfs,negotiateauth,xforms
ac_add_options --enable-xtf
ac_add_options --enable-default-toolkit=cairo-gtk2
# ac_add_options --enable-default-toolkit=gtk2
ac_add_options --enable-xft
ac_add_options --disable-freetype2
ac_add_options --disable-tests
ac_add_options --disable-debug
ac_add_options '--enable-optimize=-Os -freorder-blocks -fno-reorder-functions
-gstabs+'
ac_add_options --enable-cairo
ac_add_options --enable-svg
ac_add_options --enable-svg-renderer-cairo

I can build when --enable-default-toolkit=gtk2

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

duplicate of bug 277656?

Comment 2

[Takeshi Kurosawa :takenspc]

(In reply to comment #1)
> duplicate of bug 277656?

It may be.

*** This bug has been marked as a duplicate of 277656 ***

Comment 3

[Jungshik Shin]

Hmm... what I intended to do in bug 277656  was different from fixing the cause
of this bug.
When I filed it, I didn't know there'd be compilation errors. I just wanted to
port what's been done in nsFontMetricsXft (since cairo-xft was last updated) to
cairo-xft. 

Anyway, I also stumbled upon this problem. The fix for this particular
compilation error is trivial. After fixing it, I came acros a couple of
compilation errors. At that point, I began to wonder if anybody has ever built
cairo-gtk2. 

IMHO, build errors had better be dealt with separately from porting 'new
features and bug fixes'.

Comment 4

[Jungshik Shin]

http://lxr.mozilla.org/seamonkey/source/gfx/src/cairo/nsCairoRenderingContext.cpp#471

        /* XXX we need to add api on nsTransform2D to set all these values since
they are private */
        mTempTransform.m00 = a;
        mTempTransform.m01 = b;
        mTempTransform.m10 = c;
        mTempTransform.m11 = d;
        mTempTransform.m20 = tx;
        mTempTransform.m21 = ty;
        mTempTransform.type = MG_2DGENERAL;

Comment 5

[Takeshi Kurosawa :takenspc]

I can build it.
This bugs was resolved by roc's great work.
http://weblogs.mozillazine.org/roc/archives/2005/04/cairo_status.html