278017 - (bz-deprecateddb) Eliminate use of deprecated Bugzilla::DB routines (SendSQL, etc.)

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement, P3)

Description

[Max Kanat-Alexander]

I thought this bug was already filed... but we need to get rid of all the
SendSQL calls and so forth, and eventually eliminate those subroutines from
Bugzilla::DB.

File blockers.

Comment 1

[Teemu Mannermaa (:wicked)]

All blockers filed. After they are done, deprecated code in Bugzilla.pm and
Bugzilla/DB.pm can be removed by a patch to this bug.

Globals.pl will be dealt with in bug 87411. Files contrib/gnats2bz.pl and
contrib/gnatsparse/gnatsparse.py don't need changes because they use their own
implementation of SqlQuote and not the one in Bugzilla::DB.

Note that UPGRADING-pre-2.8 contains some example update code that uses these
deprecated routines. Not that these instructions have been updated to not use
functions like ConnectToDatabase either and are most likely broken in numerous
other ways.

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

Bug 300552 about Search.pm is under review. And all routines have been moved out of globals.pl. We can now remove everything related to deprecated DB routines.

Note that contrib/gnats2bz.pl uses its own SqlQuote() routine; just in case you wondered why I left it alone.

Comment 3

[Max Kanat-Alexander]

Comment on attachment 226249 [details] [diff] [review]
patch, v1

YES!!

Wow, I can't believe all our work is finally coming to a final product.

Comment 4

[Frédéric Buclin]

Attachment: patch, v1.1

The :deprecated tag no longer exists.

Comment 5

[Max Kanat-Alexander]

Comment on attachment 226288 [details] [diff] [review]
patch, v1.1

Sure, that also looks fine to me.

Comment 6

[Frédéric Buclin]

Checking in Bugzilla.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla.pm,v  <--  Bugzilla.pm
new revision: 1.37; previous revision: 1.36
done
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.373; previous revision: 1.372
done
Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.77; previous revision: 1.76
done

Comment 7

[Max Kanat-Alexander]

Added to the relnotes currently attached to bug 349423.