279544 - Bug.pm: Eliminate deprecated Bugzilla::DB routines

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

OK, I've done buglist.cgi with this, now it's time to go for show_bug.cgi, which
is apparently the most-used CGI.

We're removing all the SendSQL calls and so forth from the script.

Comment 1

[Max Kanat-Alexander]

Oh, actually, it turns out that show_bug itself doesn't have any SQL. :-) It's
all in Bug.pm.

Comment 2

[Max Kanat-Alexander]

Attachment: Remove SendSQL calls from Bug.pm

This was pretty easy, actually.

I tested the things that I could. Interestingly enough, Bugzilla::Bug::groups
is NEVER USED in Bugzilla, so it's impossible to test that code path. :-)

Comment 3

[Marc Schumann [:Wurblzap]]

Comment on attachment 172243 [details] [diff] [review]
Remove SendSQL calls from Bug.pm

Tested; works. Strange about that groups-not-being-called thing.

>@@ -484,17 +488,15 @@
> 
> sub EmitDependList {

Nit: it's not your fault, of course, but you've modified this little sub a lot,
so I think we could correct indentation to four spaces while we're here...
If you do, feel free to move r+ forward.

Comment 4

[Max Kanat-Alexander]

Yeah, I agree that we should do the four-spaces-indent thing and also fix the
SQL case.

Comment 5

[Max Kanat-Alexander]

Attachment: Version 1.1 (also fix EmitDependList spacing)

Comment 6

[Shane H. W. Travis]

Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.52; previous revision: 1.51
done