Closed
Bug 278962
Opened 20 years ago
Closed 20 years ago
Nested repeats are not working
Categories
(Core Graveyard :: XForms, defect)
Core Graveyard
XForms
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: allan, Assigned: allan)
References
()
Details
Attachments
(2 files)
1.92 KB,
application/xhtml+xml
|
Details | |
3.89 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Hmmm, I do not think I have ever tested that functionality... nevertheless they do not work :(
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Comment 2•20 years ago
|
||
I've been investigating a bit, and it seems like DoneAddingChildren() is never called for the cloned <repeat>s. So if I remove the mDoneAddingChildren check in nsXFormsRefreshElement::Refresh(), nested repeats seems to work. Anybody got a clue to why DoneAddingChildren is never called on the cloned nodes?
Comment 3•20 years ago
|
||
Because of this http://lxr.mozilla.org/seamonkey/source/content/xtf/public/nsIXTFElement.idl#144
Comment 4•20 years ago
|
||
You could use BeginAddingChildren() to set mDoneAddingChildren false and then in DoneAddingChildren() again to true. In the constructor mDoneAddingChildren should be set true.
Assignee | ||
Comment 5•20 years ago
|
||
(In reply to comment #4) > You could use BeginAddingChildren() to set mDoneAddingChildren false and > then in DoneAddingChildren() again to true. In the constructor mDoneAddingChildren > should be set true. Argh, of course. We have had that bug before somewhere else haven't we? Thanks smaug!
Assignee | ||
Comment 6•20 years ago
|
||
Here's a simple patch doing what smaug suggested.
Assignee | ||
Updated•20 years ago
|
Attachment #171872 -
Flags: review?(smaug)
Assignee | ||
Comment 7•20 years ago
|
||
BTW, we could consider letting nsXFormsControlStub implement this more generally, but let's do that on another bug.
Comment 8•20 years ago
|
||
Comment on attachment 171872 [details] [diff] [review] Simple patch This is ok, but needs also Bug 278973
Attachment #171872 -
Flags: review?(smaug) → review+
Assignee | ||
Comment 9•20 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•