278962 - Nested repeats are not working

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Allan Beaufour]

Hmmm, I do not think I have ever tested that functionality... nevertheless they
do not work :(

Comment 1

[Allan Beaufour]

Attachment: Testcase

Comment 2

[Allan Beaufour]

I've been investigating a bit, and it seems like DoneAddingChildren() is never
called for the cloned <repeat>s. So if I remove the mDoneAddingChildren check in
nsXFormsRefreshElement::Refresh(), nested repeats seems to work.

Anybody got a clue to why DoneAddingChildren is never called on the cloned nodes?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Because of this
http://lxr.mozilla.org/seamonkey/source/content/xtf/public/nsIXTFElement.idl#144

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

You could use BeginAddingChildren() to set mDoneAddingChildren false and
then in DoneAddingChildren() again to true. In the constructor mDoneAddingChildren
should be set true.

Comment 5

[Allan Beaufour]

(In reply to comment #4)
> You could use BeginAddingChildren() to set mDoneAddingChildren false and
> then in DoneAddingChildren() again to true. In the constructor mDoneAddingChildren
> should be set true.

Argh, of course. We have had that bug before somewhere else haven't we?

Thanks smaug!

Comment 6

[Allan Beaufour]

Attachment: Simple patch

Here's a simple patch doing what smaug suggested.

Comment 7

[Allan Beaufour]

BTW, we could consider letting nsXFormsControlStub implement this more
generally, but let's do that on another bug.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 171872 [details] [diff] [review]
Simple patch

This is ok, but needs also Bug 278973

Comment 9

[Allan Beaufour]

checked in