Closed
Bug 278973
Opened 20 years ago
Closed 20 years ago
Let nsIContextControl use nsIDOMNode instead of nsIDOMElement
Categories
(Core Graveyard :: XForms, defect)
Core Graveyard
XForms
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: allan, Assigned: allan)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
18.68 KB,
patch
|
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
There's no reason for nsIContextControl to use nsIDOMElement as the context node. The node a control is bound to and also uses as context is just a nsIDOMNode.
|
Assignee | |
Comment 1•20 years ago
|
||
Uses nsIDOMNode instead, and also solves some sloppy coding from me: nsXFormsRepeatElement and nsXFormsContextContainer was not using nsXFormsControlStub properly. It's built for the branch, and depends on at least bug 265467.
Attachment #171741 -
Flags: review?(smaug)
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•20 years ago
|
||
Comment on attachment 171741 [details] [diff] [review] Patch v1 Looks ok.
Attachment #171741 -
Flags: review?(smaug) → review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #171741 -
Flags: superreview?(darin)
|
|
Assignee | |
Updated•20 years ago
|
Attachment #171741 -
Flags: superreview?(darin)
|
|
Assignee | |
Comment 3•20 years ago
|
||
Updated to trunk
Attachment #171741 -
Attachment is obsolete: true
Attachment #171869 -
Flags: superreview?(darin)
|
||
Comment 4•20 years ago
|
||
Comment on attachment 171869 [details] [diff] [review] Patch v1 for trunk sr=darin
Attachment #171869 -
Flags: superreview?(darin) → superreview+
|
|
Assignee | |
Comment 5•20 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•