Closed
Bug 287168
Opened 19 years ago
Closed 19 years ago
CSS clip property doesn't work on Linux
Categories
(Core :: Web Painting, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: spaceman.23, Assigned: roc)
References
()
Details
Attachments
(4 files, 1 obsolete file)
11.58 KB,
patch
|
tor
:
review-
|
Details | Diff | Splinter Review |
8.14 KB,
patch
|
tor
:
review+
blizzard
:
superreview+
chofmann
:
approval1.8b2+
|
Details | Diff | Splinter Review |
96.12 KB,
image/gif
|
Details | |
807 bytes,
text/html
|
Details |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.5) Gecko/20041108 Firefox/1.0 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.5) Gecko/20041108 Firefox/1.0 This is a Linux specific bug. The clip property doesn't seems to work on elements like DIV or SPAN. Reproducible: Always Steps to Reproduce: 1. go to http://spaceman.23.free.fr/clipbug/clipbug.html with a linux gecko browser 2. go to the same URL with a windows gecko browser Actual Results: The image is not clipped when using a linux gecko browser Expected Results: The image should be cliped
Reporter | ||
Updated•19 years ago
|
Flags: blocking-aviary1.1?
Reporter | ||
Updated•19 years ago
|
Flags: blocking-aviary1.1?
Comment 1•19 years ago
|
||
Did it work before? Does it work in a recently nightly?
Reporter | ||
Comment 2•19 years ago
|
||
I tested with firefox release: 0.8, 0.9, 1.0 and mozilla 1.7.2. Someone told me it fails on galeon too. But it works well on Windows and MacOS releases. This CSS property probably never worked on linux gecko bowsers.
Reporter | ||
Comment 3•19 years ago
|
||
And of course, it doesn't work on nightlies too.
Assignee | ||
Comment 4•19 years ago
|
||
Is it the clip property, or image drawing? Have you tried clipping something other than an image?
Reporter | ||
Comment 5•19 years ago
|
||
Yes you are true: the text in the <div> is clipped. But the background image of the <div> is not clipped under Linux.
Assignee | ||
Comment 6•19 years ago
|
||
are you using a GTK1 or GTK2 build?
Reporter | ||
Comment 7•19 years ago
|
||
I usualy use Firefox1.0x/GTK2 but I tested with Firefox0.8/GTK1. The same bug occurs
Assignee | ||
Comment 8•19 years ago
|
||
what nightly build did you test with?
Reporter | ||
Comment 9•19 years ago
|
||
I tested with: - firefox 0.8(GTK1 >K2), 0.9, 1.0, 1.0.2, nigthly(Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050405) - mozilla 1.7.2(Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.7.2) Gecko/20040804) The bug occured in all this versions.
Assignee | ||
Comment 10•19 years ago
|
||
GTK image tiling code ignores the clip rect in most cases. It also misinterprets the 'valid' out parameter of GetClipRect. This patch fixes the issues.
Attachment #180331 -
Flags: superreview?(blizzard)
Attachment #180331 -
Flags: review?(tor)
Comment 11•19 years ago
|
||
Comment on attachment 180331 [details] [diff] [review] fix I think your change to SlowTile won't work, due to Xlib not seperating the concept of the clip mask and rectangles, so only one can be set (the second overrides the first). You'll need to intersect it with aTileRect and draw the result in the gdk_window_copy_area. You've got some debug printfs in nsCSSRendering.cpp and nsPresShell.cpp that should be removed.
Attachment #180331 -
Flags: review?(tor) → review-
Assignee | ||
Comment 12•19 years ago
|
||
Here's the code that does what you want.
Attachment #180331 -
Attachment is obsolete: true
Attachment #180432 -
Flags: superreview?(blizzard)
Attachment #180432 -
Flags: review?(tor)
Assignee | ||
Updated•19 years ago
|
Attachment #180331 -
Attachment is obsolete: false
Attachment #180331 -
Flags: superreview?(blizzard)
Attachment #180432 -
Flags: review?(tor) → review+
Updated•19 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•19 years ago
|
Attachment #180432 -
Flags: superreview?(blizzard) → superreview+
Assignee | ||
Comment 13•19 years ago
|
||
Comment on attachment 180432 [details] [diff] [review] fix #2 fixes a rather embarrassing longstanding clipping bug on Linux
Attachment #180432 -
Flags: approval1.8b2?
Comment 14•19 years ago
|
||
Comment on attachment 180432 [details] [diff] [review] fix #2 a=chofmann
Attachment #180432 -
Flags: approval1.8b2? → approval1.8b2+
Assignee | ||
Comment 15•19 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 16•19 years ago
|
||
The fix for this bug has caused bug 291965.
Assignee | ||
Comment 17•19 years ago
|
||
for safekeeping, here's the testcase I used.
Assignee | ||
Comment 18•19 years ago
|
||
oops, I need to fix this image
Attachment #182103 -
Attachment is obsolete: true
Assignee | ||
Comment 19•19 years ago
|
||
Comment 20•19 years ago
|
||
Wow thank you for fixing this bug finally!! Thank you, Thank you, Thank you!!
Updated•6 years ago
|
Component: Layout: View Rendering → Layout: Web Painting
You need to log in
before you can comment on or make changes to this bug.
Description
•