287168 - CSS clip property doesn't work on Linux

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Bruno Pouyenne]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.5) Gecko/20041108 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.5) Gecko/20041108 Firefox/1.0

This is a Linux specific bug. The clip property doesn't seems to work on
elements like DIV or SPAN.


Reproducible: Always

Steps to Reproduce:
1. go to http://spaceman.23.free.fr/clipbug/clipbug.html with a linux gecko browser
2. go to the same URL with a windows gecko browser
Actual Results:  
The image is not clipped when using a linux gecko browser

Expected Results:  
The image should be cliped

Comment 1

[Anne (:annevk)]

Did it work before? Does it work in a recently nightly?

Comment 2

[Bruno Pouyenne]

I tested with firefox release: 0.8, 0.9, 1.0 and mozilla 1.7.2. Someone told me
it fails on galeon too. But it works well on Windows and MacOS releases.

This CSS property probably never worked on linux gecko bowsers. 

Comment 3

[Bruno Pouyenne]

And of course, it doesn't work on nightlies too.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Is it the clip property, or image drawing? Have you tried clipping something
other than an image?

Comment 5

[Bruno Pouyenne]

Yes you are true: the text in the <div> is clipped. 
But the background image of the <div> is not clipped under Linux.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

are you using a GTK1 or GTK2 build?

Comment 7

[Bruno Pouyenne]

I usualy use Firefox1.0x/GTK2 but I tested with Firefox0.8/GTK1. The same bug
occurs 

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

what nightly build did you test with?

Comment 9

[Bruno Pouyenne]

I tested with: 
- firefox 0.8(GTK1 &GTK2), 0.9, 1.0, 1.0.2, nigthly(Mozilla/5.0 (X11; U; Linux
i686; en-US; rv:1.8b2) Gecko/20050405) 
- mozilla 1.7.2(Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.7.2) Gecko/20040804)

The bug occured in all this versions. 

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

GTK image tiling code ignores the clip rect in most cases. It also
misinterprets the 'valid' out parameter of GetClipRect. This patch fixes the
issues.

Comment 11

[tor]

Comment on attachment 180331 [details] [diff] [review]
fix

I think your change to SlowTile won't work, due to Xlib not seperating
the concept of the clip mask and rectangles, so only one can be set
(the second overrides the first).  You'll need to intersect it with
aTileRect and draw the result in the gdk_window_copy_area.

You've got some debug printfs in nsCSSRendering.cpp and
nsPresShell.cpp that should be removed.

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix #2

Here's the code that does what you want.

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 180432 [details] [diff] [review]
fix #2

fixes a rather embarrassing longstanding clipping bug on Linux

Comment 14

[chris hofmann]

Comment on attachment 180432 [details] [diff] [review]
fix #2

a=chofmann

Comment 15

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 16

[Jan Darmochwal]

The fix for this bug has caused bug 291965.

Comment 17

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: testcase

for safekeeping, here's the testcase I used.

Comment 18

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: image needed for testcase

oops, I need to fix this image

Comment 19

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: real testcase

Comment 20

[Mark D.]

Wow thank you for fixing this bug finally!!
Thank you, Thank you, Thank you!!