291965 - background images with transparency not drawn/redrawn correctly

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Jan Darmochwal]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050426
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050426

With the latest nightly build the table background image in
mozilla/layout/html/tests/table/marvin/backgr_simple-table.html do not render
correctly. I will add a testcase.


Reproducible: Always

Steps to Reproduce:
1. see testcase
Actual Results:  
background is broken (I will add a screenshot as well)

Expected Results:  
background renders correcly

Comment 1

[Jan Darmochwal]

Attachment: testcase

Comment 2

[Jan Darmochwal]

Attachment: screenshot of testcase

Comment 3

[Jan Darmochwal]

Attachment: possible fix

This bug is caused by these lines from the fix for bug 287168:

+    if (haveClip) {
+      GdkRectangle gdkrect = {clipRect.x + aTileRect.x - aSXOffset,
+			       clipRect.y + aTileRect.y - aSYOffset,
+			       clipRect.width, clipRect.height};
+      gdk_gc_set_clip_rectangle(tileGC, &gdkrect);
+    }

Using

+      GdkRectangle gdkrect = {clipRect.x, clipRect.y,
+			       clipRect.width, clipRect.height};

instead seems to work fine, but someone who knows this code should check that.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 181931 [details] [diff] [review]
possible fix

I'm trying to remember what I was thinking when I wrote that code, but I'm
failing. This is clearly the correct code, and it passes my tests. Thanks!

This patch fixes a regression I just introduced in Linux clipping.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 181931 [details] [diff] [review]
possible fix

a=asa

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I checked this in yesterday.