Closed
Bug 291775
Opened 19 years ago
Closed 19 years ago
The Print Preview toolbar always shows page 1 of 1
Categories
(Core :: Print Preview, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: zug_treno, Assigned: roc)
References
()
Details
Attachments
(1 file)
1.70 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
chofmann
:
approval1.8b2+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050217 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050424 The "Page:" field at the top of the Print Preview window thinks there's only 1 page. You can't navigate to the next (or last) page although there are more pages visible if you scroll down. Reproducible: Always Steps to Reproduce: 1.Go to http://www.mozilla.org/products/mozilla1.x/. (or any other long page). 2.Choose File>Print Preview. Actual Results: Toolbar shows 'Page: |< < [1 ] of 1 > >|'. Expected Results: Toolbar shows 'Page: |< < [1 ] of 2 > >|'. I also see this bug with Gecko/20050424 Firefox/1.0+ but I don't see this bug with Mozilla 1.8b1, this regression might be related to bug 291485.
Comment 1•19 years ago
|
||
Confirming+marking as dep, since regression timeframe matches and the other bug also affects Print Preview. So i guess this is a more general problem...
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 2•19 years ago
|
||
This is broken because it's searching for the page sequence frame using only the first-child links ... and now a scrollbar is the first-child of the viewport. We should just use the new direct accessor to the page sequence frame (that I added to fix another bug just like this one).
Assignee: printing → roc
Status: NEW → ASSIGNED
Attachment #181825 -
Flags: superreview?(bzbarsky)
Attachment #181825 -
Flags: review?(bzbarsky)
Updated•19 years ago
|
Attachment #181825 -
Flags: superreview?(bzbarsky)
Attachment #181825 -
Flags: superreview+
Attachment #181825 -
Flags: review?(bzbarsky)
Attachment #181825 -
Flags: review+
Assignee | ||
Comment 3•19 years ago
|
||
Comment on attachment 181825 [details] [diff] [review] fix fix regression in print preview UI
Attachment #181825 -
Flags: approval1.8b2?
Comment 4•19 years ago
|
||
Comment on attachment 181825 [details] [diff] [review] fix a=chofmann
Attachment #181825 -
Flags: approval1.8b2? → approval1.8b2+
Assignee | ||
Comment 5•19 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•