291775 - The Print Preview toolbar always shows page 1 of 1

Status: RESOLVED FIXED

(Core :: Print Preview, defect)

Description

[zug_treno]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050217
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050424

The "Page:" field at the top of the Print Preview window thinks there's only 1
page. You can't navigate to the next (or last) page although there are more
pages visible if you scroll down.

Reproducible: Always

Steps to Reproduce:
1.Go to http://www.mozilla.org/products/mozilla1.x/. (or any other long page).
2.Choose File>Print Preview.

Actual Results:  
Toolbar shows 'Page: |< < [1  ] of 1 > >|'.

Expected Results:  
Toolbar shows 'Page: |< < [1  ] of 2 > >|'.

I also see this bug with Gecko/20050424 Firefox/1.0+ but I don't see this bug
with Mozilla 1.8b1, this regression might be related to bug 291485.

Comment 1

[Frank Wein [:mcsmurf]]

Confirming+marking as dep, since regression timeframe matches and the other bug
also affects Print Preview. So i guess this is a more general problem...

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This is broken because it's searching for the page sequence frame using only
the first-child links ... and now a scrollbar is the first-child of the
viewport. We should just use the new direct accessor to the page sequence frame
(that I added to fix another bug just like this one).

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 181825 [details] [diff] [review]
fix

fix regression in print preview UI

Comment 4

[chris hofmann]

Comment on attachment 181825 [details] [diff] [review]
fix

a=chofmann

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in