292012 - cairo-gtk2 toolkit does not build unless --enable-cairo is given

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

In configure.in, cairo-gtk2 does enable cairo:
3418    MOZ_ENABLE_CAIRO=1

However, it does not AC_DEFINE that, that's only done for --enable-cairo,
earlier in the file:
3290 MOZ_ARG_ENABLE_BOOL(cairo,
3291 [  --enable-cairo          Enable Cairo-specific features (Canvas)],
3292     MOZ_ENABLE_CAIRO=1,
3293     MOZ_ENABLE_CAIRO= )
3294 if test "$MOZ_ENABLE_CAIRO"; then
3295     AC_DEFINE(MOZ_ENABLE_CAIRO)
3296 fi

this inconsistency causes the build to fail while canvas is built:
/home/chb/mozilla/content/canvas/src/nsCanvasRenderingContext2D.cpp: In member
function `virtual nsresult nsCanvasGradient::QueryInterface(const nsIID&, void**)':
/home/chb/mozilla/content/canvas/src/nsCanvasRenderingContext2D.cpp:126: Fehler:
`eDOMClassInfo_CanvasGradient_id' undeclared (first use this function)
[...etc...]

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Pretty sure this is invalid now, as --enable-cairo became --enable-canvas, and I
believe things that need cairo explicitly enable it.  If cairo-gtk2 still
doesn't build, then that's probably a separate non-canvas issue.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

I would say it's fixed by bug 293265