293265 - Rename --enable-cairo to --enable-canvas

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[tor]

Mozilla can use cairo for three different things (gfx, svg, and canvas), so
naming the html:canvas option --enable-cairo is causing confusion based on what
I've seen in #developers.

Comment 1

[tor]

Attachment: rename config option

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

looks like this may fix bug 292012

Comment 3

[ArronM (:paper)]

Comment on attachment 182873 [details] [diff] [review]
rename config option

 dnl check whether to enable cairo
 dnl ========================================================
 MOZ_ARG_ENABLE_BOOL(cairo,

Shouldn't the first parameter be changed from cairo to canvas too?  As well as
the comment.

Comment 4

[tor]

Attachment: address Arron's comments

Comment 5

[Benjamin Smedberg]

Comment on attachment 183027 [details] [diff] [review]
address Arron's comments

Is this patch supposed to default canvas off?

Comment 6

[tor]

I just left the default as it was before, off.  Switching the default on canvas
has the same problems as turning on svg by default right now - the build prereqs
will turn most of -ports red.  I think the thought is to just enable it
explicity on the appropriate moz tinderboxes until the owners can be reminded of
upcoming requirements.

Comment 7

[Chase Phillips]

Comment on attachment 183027 [details] [diff] [review]
address Arron's comments

a=asa via rl.  Let's get this on the trunk and I'll switch the build machines
to use the new flag asap after it hits.

Comment 8

[tor]

Checked in.