293235 - When fastback is enabled and back button (or keyboard) is used, visited links are not marked as visited

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[philippe (part-time)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050507 Firefox/1.0+  (phiw13)
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050507 Firefox/1.0+  (phiw13)

Since the landing of bug 274784, when using the backbutton, a link that just has
been visited is not marked/displayed as visited.
Visit the test page, follow the link, and use the backbutton to come back. The
link will have still be focussed (a:focus); that is OK. Once it loses the focus
(clicking anywhere to shift the focus, it will still be blue (a:link), whereas I
expect it to be green (a:visited).
[Reloading the page, and the link will turn green.]

Sidenote - Opera 8beta for OS X turns the link green. Right now, I've no access
to a windows box to test Opera 8 win.

Reproducible: Always

Steps to Reproduce:
1.load test case
2.follow link (the top one is OK).
3.use backbutton or keyboard to step back to first page

Actual Results:  
the link has still focus (OK), once deselected, it displays as blue (the color
assigned to a:link).

Expected Results:  
Display the link as green (the color assigned by a:visited).

Both official nightly and my own build. New profile, empty cache for testing
purposes.

Comment 1

[philippe (part-time)]

Forgot to add: browser.sessionhistory.max_viewers is set to 5.

Comment 2

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050506
Firefox/1.0+
I see this too, when bfcache is enabled.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

bug 78510 would probably fix this

Comment 4

[Worcester12345]

(In reply to comment #3)
> bug 78510 would probably fix this

Should this be marked as a dependency one way or the other?

Comment 5

[Anbo Motohiko]

Attachment: patch for workaround

This is only for workaround. Mark link visited as link is middle-clicked.

This patch has same problem as middle-clicking link; a link which actually
clicked is only marked as visited, other links which have same URI are still
shown as unvisited.

Comment 6

[Worcester12345]

Also, just wondering, but if the same link is in other places on the same page,
those are not marked either, just the original. Thanks.

Comment 7

[Steve Chapel]

(In reply to comment #6)
> Also, just wondering, but if the same link is in other places on the same page,
> those are not marked either, just the original. Thanks.

I believe that's bug 78510.

Comment 8

[Brian Ryner (not reading)]

This doesn't depend on 78510.  We can reresolve style on links when restoring a
page.

Comment 9

[Darin Grimm]

At this risk of this being considered bugspam, is there anyway this can be fixed
for 1.8b3?  I realize the blocking flag has been minused, so will not nominate
again, but this does appear to be probably the single issue that are large
number of people have an issue with in the daily use of "blazingfastback".  

Assuming this cannont be fixed for 1.8b3, I think clearly documenting the issue
in release notes (for the 5% of people that read them) would be good

Comment 10

[Jaime Mitchell (use [e-mail] for email)]

*** Bug 299869 has been marked as a duplicate of this bug. ***

Comment 11

[:Gavin Sharp [email: [e-mail]]]

*** Bug 301001 has been marked as a duplicate of this bug. ***

Comment 12

[Brian Ryner (not reading)]

Targetting to match blocking status (and get off the
untargetted-fastback-dependencies list).

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 302154 has been marked as a duplicate of this bug. ***

Comment 14

[Chris Beard]

bryner, can you fix it the "right way" in the next week?  or should we take the
workaround?

/cb

Comment 15

[Elmar Ludwig]

*** Bug 302431 has been marked as a duplicate of this bug. ***

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 303131 has been marked as a duplicate of this bug. ***

Comment 17

[Recall]

(In reply to comment #16)
> *** Bug 303131 has been marked as a duplicate of this bug. ***

Can someone mark this as fixed,
https://bugzilla.mozilla.org/show_bug.cgi?id=78510 has just been checked in and
fixes this bug

Comment 18

[Jonathan Griffin (:jgriffin)]

Attachment: mochitest test case

Comment 19

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 387544 [details] [diff] [review]
mochitest test case

Nice.

Comment 20

[Boris Zbarsky [:bzbarsky]]

Pushed test as http://hg.mozilla.org/mozilla-central/rev/36757da19bbb