298293 - turn on fastback by default in ff 1.1a2 / gecko 1.8b3

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Brian Ryner (not reading)]

tracking bug for bugs blocking default setting of fastback to on

Comment 1

[Brian Ryner (not reading)]

Adding a few bugs I know need to be fixed; more coming soon probably.

Comment 2

[Asaf Romano (gone)]

mac blocker: bug 298112

Comment 3

[Benjamin Smedberg]

plus to get it on the list at least.

Comment 4

[Brian Ryner (not reading)]

Attachment: patch

pre-requesting review and approval to enable this once the blocking bugs are
landed

Comment 5

[Brian Ryner (not reading)]

sicking and I decided that 293235 is not really an alpha blocker

Comment 6

[chris hofmann]

talking with bryner
https://bugzilla.mozilla.org/showdependencytree.cgi?id=274784&hide_resolved=1
has the remaining outstanding issues that could be worked out after flipping the
switch.

Comment 7

[chris hofmann]

the current state of that list looks like

    *  bug 292890 [---, [e-mail]] -Investigate interaction of
bfcache/fastback and midas.
    * bug 292938 [---, [e-mail]] -Slight hitch when using back/forward
with bfcache/fastback.
    * bug 292945 [---, [e-mail]] -bfcache/fastback code can
synchronously trigger off a timeout.
    * bug 292955 [---, [e-mail]] -fastback/bfcache doesn't work
well with framesets.
    * bug 292958 [---, [e-mail]] -Blink timers not disabled in
cached presentations.
    * bug 292959 [---, [e-mail]] -What to do with computed style objects
for DOM nodes in a cached presentations?.
    * bug 292965 [---, [e-mail]] -Improve eviction algorithm for
fastback/bfcache.
    * bug 292969 [---, [e-mail]] -Thawing presshell could
synchronously reenter nsDocShell::RestorePresentation.
    * bug 292970 [---, [e-mail]] -Firing restore events can reenter
nsDocShell::RestorePresentation.
    * bug 292976 [---, [e-mail]] -Various PLEvents and timers can fire
on cached presentations.
    * bug 292977 [---, [e-mail]] -Restoring window state can reenter
state restoration.
    * bug 292978 [---, [e-mail]] -Firing restore events can mutate the
docshell tree.
    * bug 292980 [---, [e-mail]] -Recursion into frames when
freezing/thawing presshell should happen in the document.
    * bug 292998 [---, [e-mail]] -fastback/bfcache should be
invalidated after a text resize.
    * bug 293175 [---, [e-mail]] -Inconsistent document container handling.
    * bug 293235 [---, [e-mail]] -when using the back button (or
keyboard), visited links are not marked as visited.
    * 293386 [---, [e-mail]] -Audit UnbindFromTree codepaths to
make sure teardown change is OK.
    * bug 293572 [---, [e-mail]] -Local Proxy (AdMuncher) breaks bfcache.
    * bug 294610 [---, [e-mail]] -fastback/bfcache remembers DOM
state after event processing on page quit.
    * bug 295591 [---, [e-mail]] -blazingly fast for/backward
overwrites? svg objects.
    * bug 295931 [---, [e-mail]] -With bfcache enabled, rocker
navigation stops text entry into textarea.
    * bug 296575 [---, [e-mail]] -RSS statusbar icon not (re)enabled
after pressing back using bfcache.
    * bug 296760 [---, [e-mail]] -[MAS, v1.8b2-0605++] (new) "Various"
crashes with bfcache ON.
    * bug 297488 [---, [e-mail]] -Irregular crashes when closing
tab/windows or quiting Camino with bfcache enabled [@ nsChildView::GetParent() +
0x24].
    * bug 297887 [---, [e-mail]] -Form values are not correct with
bfcache enabled.
    * bug 298077 [---, [e-mail]] -Link remains focused when going back to
the previous page using the back button and the focus can not be undone..
    * bug 298125 [---, [e-mail]] -Back/forward cache becomes confused
on bug lists.
    * bug 298622 [---, [e-mail]] -find fails on page with url typed.

Comment 8

[chris hofmann]

bug 298377 DP 1.1a1 breaks dojo.io.bind's back-button interception should also
get sorted out before 1.1 final too...

Comment 9

[chris hofmann]

anything else that has turned up in recent testing with the pref turned on?

Comment 10

[Brian Ryner (not reading)]

I'm not aware of any problems that aren't on the 274784 list.  I think we should go ahead and flip the 
switch.

Comment 11

[Asaf Romano (gone)]

also see bug 298622 (recent bfcache-only regression).

Comment 12

[chris hofmann]

byner can you look at https://bugzilla.mozilla.org/show_bug.cgi?id=299008

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

that bug claims to be reproducable with fastback disabled.

Comment 14

[Chris Beard]

OK, it looks like we're ready to set fastback pref'd on for 1.8b3.  We're using
this alpha release as an oppportunity to obtain wider testing and quality
feedback, to evaluate whether or not it's enabled in 1.1.  final code review to
be lead by bz and brendan by 1.8b4.

Comment 15

[Darin Fisher]

Comment on attachment 187171 [details] [diff] [review]
patch

3 not 5?  ok, r=darin

Comment 16

[Brian Ryner (not reading)]

checked in, thanks guys.

Comment 17

[Boris Zbarsky [:bzbarsky]]

I feel that bug 292965 should have been a blocker for this... The current
eviction algorithm leads to quite painful results any time multiple tabs/windows
are used, and if we're going to test we should test with the "final" eviction
algorithm.

Comment 18

[Aaron Leventhal]

This broke screen reader usage, see bug 300642.