Closed Bug 304504 Opened 19 years ago Closed 19 years ago

MOZCONFIG_MODULES duplicates entries

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bryner, Assigned: bryner)

Details

(Keywords: fixed1.8)

Attachments

(1 file, 1 obsolete file)

real patch
659 bytes, patch
benjamin
: review+
benjamin
: approval1.8b4+
Details | Diff | Splinter Review 
MOZCONFIG_MODULES in client.mk duplicates all of the modules/directories
assigned to it.
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #192548 -
        Flags: review?(benjamin)

    
    

    
  
Was this caused by bug 304505? I don't understand why we're changing the
assignment mode or not-appending to mozconfig-modules.

    
    

    
  
I noticed this problem when trying to pull minimo from the 1.8 branch... the 
line as-is in client.mk doesn't make much sense to me.  The point of the 
$(sort), as commented in the file, is to remove duplicates, but instead we're 
duplicating every item in MOZCONFIG_MODULES.

    
    

    
  
Comment on attachment 192548 [details] [diff] [review]
patch

I prefer the solution in bug 304505

        Attachment #192548 -
        Flags: review?(benjamin) → review-

    
    

    
  
We should take both patches... this line as it is serves no useful purpose.

    
    

    
  
Are you sure you didn't mean to patch line 347? That's the call to $(sort),
which would make a lot more sense.

    
    

    
  
Hah, you're right, that is what I meant to patch.  I think I misapplied this 
when I moved my patch over to the trunk.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        real patch
        — 
          — Splinter Review
      

    


  
This is what I meant to do, and what I actually verified fixed the minimo
problem on the 1.8 branch.  I just messed up when I manually applied the patch
to the trunk.

        Attachment #192548 -
        Attachment is obsolete: true

        Attachment #192903 -
        Flags: review?(benjamin)

    
    

    
  
Comment on attachment 192903 [details] [diff] [review]
real patch

Much better ;-)

        Attachment #192903 -
        Flags: review?(benjamin)

        Attachment #192903 -
        Flags: review+

        Attachment #192903 -
        Flags: approval1.8b4+

    
    

    
  
checked in on trunk and branch
Status: NEW → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8
Resolution: --- → FIXED

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: