304505 - bootstrap and modules in client.mk should list specific modules and files

Status: RESOLVED FIXED

(Minimo Graveyard :: Build Config, defect, P1)

Description

[Chase Phillips]

The minimo project in client.mk should list specific modules and files for its
BOOTSTRAP and MODULES sections.  Currently, a CVS error of '... this file is in
the way' when someone attempts to checkout the minimo or all projects.  This
problem exists on the Mozilla 1.8 branch and trunk.

Benjamin, this is the likely cause of why I couldn't pull by date from the trunk
earlier today.

Comment 1

[Doug Turner (:dougt)]

vlad is testing a patch.  This needs to be fixed on both the trunk and the branch.

Comment 2

[Chase Phillips]

See related bug 304504.

Comment 3

[Benjamin Smedberg]

Attachment: Don't use BOOTSTRAP when you don't need to

This seems really simple to me... why use BOOTSTRAP_minimo at all?

Comment 4

[Doug Turner (:dougt)]

I use it because I have a mozconfig file in :  mozilla/minimo/config/mozconfig/

Comment 5

[Benjamin Smedberg]

doug, if you really need to check out those mozconfig files during bootstrap, we
should list the mozilla/minimo/config/mozconfig/* files individually in
BOOTSTRAP_minimo and mozilla/minimo in MODULES_minimo.

Comment 6

[Chase Phillips]

(In reply to comment #5)
> doug, if you really need to check out those mozconfig files during bootstrap, we
> should list the mozilla/minimo/config/mozconfig/* files individually in
> BOOTSTRAP_minimo and mozilla/minimo in MODULES_minimo.

I agree, this is probably what dougt wants.

Comment 7

[Doug Turner (:dougt)]

The problem is that list might grow overtime.  Why can't we just pull a directory?

Comment 8

[Chase Phillips]

(In reply to comment #7)
> The problem is that list might grow overtime.  Why can't we just pull a directory?

Is that really a big problem?  If the list grows over time we adding to it won't
be that hard, or if it does get difficult look at pulling the config/ directory
itself.

I'd like for us to fix this on the branch and trunk (wherever it's not already
fixed) soon so I can pull the 'all' project by-date for tagging.

Comment 9

[Doug Turner (:dougt)]

sure, i don't really care which way you go; however I am confused why you can
pull a directory in bootstrap.

Comment 10

[Benjamin Smedberg]

This was already fixed on branch. I just checked in trunk to make it match the
branch. Doug, feel free to add the indivdual mozconfig files to BOOTSTRAP_minimo
as needed. The reason you can't checkout a directory during the bootstrap phase
is that the sticky-date gets set on the directory in a way that confuses CVS.