Closed
Bug 30579
Opened 24 years ago
Closed 21 years ago
"Scrollbar corner" should be skinnable (currently always white / displaying random garbage)
Categories
(SeaMonkey :: UI Design, defect, P2)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
FIXED
Future
People
(Reporter: jruderman, Assigned: roc)
References
()
Details
(Keywords: polish)
Attachments
(5 files, 1 obsolete file)
1.60 KB,
image/gif
|
Details | |
12.77 KB,
patch
|
bryner
:
review+
bryner
:
superreview+
asa
:
approval1.6b+
|
Details | Diff | Splinter Review |
718 bytes,
patch
|
Details | Diff | Splinter Review | |
25.02 KB,
image/png
|
Details | |
95 bytes,
text/html
|
Details |
When both horizontal and vertical scrollbars are visible on a page, the bottom- right corner should be light gray instead of white. (Example: http://www.itsajob.com/ at 800x600 resolution) Possibly related: bug #21890, documents can style their own scrollbars.
Comment 1•24 years ago
|
||
Confirmed with the 2000-03-05-08-M15 nightly binary on WinNT -- but see the 2000-03-01 comment in bug 20996, where the same region is described as grey. Possible that the latter was seen on linux. Seems possible that this region just missed getting a colour defined.
Assignee: cbegle → evaughan
Status: UNCONFIRMED → NEW
Component: Browser-General → XP Toolkit/Widgets
Ever confirmed: true
QA Contact: asadotzler → claudius
Updated•24 years ago
|
Target Milestone: M16 → M17
Comment 4•24 years ago
|
||
The corner is the the color of the window background. If the background is gray it will be gray. XPApps needs to fixe this.
Assignee: evaughan → ben
Status: ASSIGNED → NEW
Component: XP Toolkit/Widgets → XPApps
Comment 6•24 years ago
|
||
this is a stale bug. it has not been looked at in 30 days. it doens't reproduce and i suggest it be marked "WFM"
Comment 7•24 years ago
|
||
still there for _Win98__ build from 2000071008
Comment 8•24 years ago
|
||
Kenneth - what platform/os/build variation were you using when you saw the square between the ends of the scrollbars was grey? Using the 2000-07-17-08-M17 nightly binary on WinNT, that area is still white. Added URL above for ease of reproduction: it's a big photo of a bear.
Comment 9•24 years ago
|
||
GFXScrollFrame needs to be XBL so that we can style this individually in an appropriate way. future.
Status: NEW → ASSIGNED
Target Milestone: M21 → Future
Comment 10•24 years ago
|
||
*** Bug 56989 has been marked as a duplicate of this bug. ***
Comment 11•24 years ago
|
||
The square is your default HTML background color, not necessarily white -- in my case, it's pale yellow, no matter what the color of the Web page I'm currently visiting. You shouldn't be able to apply only a background color to this area: in the Mac Classic theme, for example, it should have a 1px raised bevel.
OS: Windows 98 → All
Hardware: PC → All
Summary: "Scrollbar corner" should be light gray → "Scrollbar corner" should be skinnable
Comment 12•24 years ago
|
||
*** Bug 61609 has been marked as a duplicate of this bug. ***
Comment 13•24 years ago
|
||
Stealing comments from bug 61609 to help in reproducing this: In Edit->Prefs uncheck "Use windows colors" and set the background color to something noticable (Green?). Go to a page and size the windows so both scrollbars show up. In the "notch" to the right of the horizontal scrollbar and below the vertical scrollbar you can see the background color you selected (green). This looks odd. I'd think that the skins should use the gray (ThreeDFace? Window?) color here like Navigator 4 did. Even with the background color set to white (as with the Windows default) this looks strange when viewing a page that has a background color that is dark. Reproducable always.
Comment 14•24 years ago
|
||
I believe this is a toolkit bug. GFX Scrollframe needs to be some kind of XBL widget. I mentioned this to hyatt and he said 'that's hard'... nonetheless, reassigning to XPToolkit.
Assignee: ben → trudelle
Status: ASSIGNED → NEW
Comment 16•24 years ago
|
||
blake: you mentioned this bug...
Comment 18•23 years ago
|
||
Proposing for mozilla1.0. I would say mozilla0.9.3, but it's not a valid keyword. This looks silly.
Keywords: mozilla1.0
Comment 19•23 years ago
|
||
*** Bug 89654 has been marked as a duplicate of this bug. ***
Comment 20•23 years ago
|
||
*** Bug 91929 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 21•23 years ago
|
||
Adding "white" to summary to make this bug easier to find.
Summary: "Scrollbar corner" should be skinnable → "Scrollbar corner" should be skinnable (currently always white)
Updated•23 years ago
|
Blocks: advocacybugs
Comment 22•23 years ago
|
||
Is this part of HTML or skin/theme?
Comment 23•23 years ago
|
||
*** Bug 94058 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 24•23 years ago
|
||
*** Bug 107497 has been marked as a duplicate of this bug. ***
Comment 25•23 years ago
|
||
Bug 107497 above, suggests a possible INTERIM solution based on the scrollbar properies i.e. no additional xul element is necessary because all the properties are derived from the current scrollbar style e.g. width, height, background-color, border, etc However in the longer term, I would like to be able to attach events to this area as well as dynamically display/switch a document state icon
Comment 26•23 years ago
|
||
The change happened earlier, but at least as of Build ID: 2001120303, this problem seems to have been addressed, although differently than suggested here. Instead of having a white, non-skinnable corner box, there is now a non-skinnable encryption icon. The encryption icon was moved. Should this bug be resolved?
Comment 27•23 years ago
|
||
Sorry Im only upto 9.6 (2001112009). I would expect a minimum fix would define a new 'type' option so that the corner can be styled. (in the same way as scrollbarbutton tests for type='increment') scrollbar[type="corner"] { background-image: url("chrome://...") ; background-color:#cccccc; border:1px outset white; } Does the fix permit this this?
Comment 28•23 years ago
|
||
in fact it probably makes more sense to regard the scrollbar corner as a psuedo slider element? slider[type="corner"] { background-image: url("chrome://...") ; background-color:#cccccc; border:1px outset white; }
Comment 29•23 years ago
|
||
spacer[..]
Comment 30•23 years ago
|
||
I don't understand the proposal to make it light gray. While that would look just fine with the NS4.7 look-alike skin as well as the modern skin, other skins (such as that colorful toys one) that use color-schemes not based on shades of blues/greys would look out of place. So we'd be creating a problem by fixing one. Either the corner should be skinnable, or we should change where the scrollbars go. Something like the little photoshop job I've done over here: http://www.shyonline.net/corner.gif In such a scenario, there is no need for a little box to even be there. Of course, no other browser I've seen does this, but it certainly looks better than a little white square.
Comment 31•23 years ago
|
||
when fixing this, please keep in mind that there is some code laying around cornerview::paint which is intended to show content quality. Hmmm it would be good to get this working.
Comment 32•22 years ago
|
||
This seems to be getting worse. In WIN XP, (classic theme) the scrollbar corner is a dark grey (maybe it has been for a while) but it just looks really out of place with the light colors of classic. Modern theme still has the white space. Also I've noticed that if you right click on the corner between the toolbars, it will bring up the context menu, which should not happen. This bug was opened in 2000. When will mozilla's UI get the polish it needs? It seems like nobody cares.
Comment 33•22 years ago
|
||
*** Bug 157245 has been marked as a duplicate of this bug. ***
Comment 34•22 years ago
|
||
Why waste a bit of screen estate?
Comment 35•22 years ago
|
||
That's a Windows-only solution, CT.
Comment 36•22 years ago
|
||
*** Bug 187166 has been marked as a duplicate of this bug. ***
Comment 37•21 years ago
|
||
It seems that different versions/platforms/configurations do different things with this corner. Here (2003042808, Mac OS X, Modern theme), that corner just isn't drawn at all. This means that when the page is turned or a tab is switched, whatever is there is whatever was at that screen position on the last page or tab. This could be the background of the last page, a scroll arrow, or quite a mess on resizing of the window.
Summary: "Scrollbar corner" should be skinnable (currently always white) → "Scrollbar corner" should be skinnable (currently always white / displaying random garbage)
Comment 38•21 years ago
|
||
*** Bug 208223 has been marked as a duplicate of this bug. ***
Comment 39•21 years ago
|
||
*** Bug 213861 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 40•21 years ago
|
||
I didn't get random garbage in the scrollbar corner when I reported this bug. That seems to be a new problem.
Comment 41•21 years ago
|
||
*** Bug 214496 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 42•21 years ago
|
||
Mine, since I pretty much own scrolling now
Assignee: eric → roc+moz
Priority: P3 → P2
Assignee | ||
Comment 43•21 years ago
|
||
This patch adds a "scrollcorner" XUL box element which is sized and placed appropriately in all scroll frames that have two scrollbars. Themes can style this element. This patch is small and low risk.
Assignee | ||
Comment 44•21 years ago
|
||
Comment on attachment 135713 [details] [diff] [review] fix wondering if we can get this into 1.6b
Attachment #135713 -
Flags: superreview?(dbaron)
Attachment #135713 -
Flags: review?(dbaron)
Assignee | ||
Comment 45•21 years ago
|
||
The hunk in xpfe/global/resources/content/xul.css is not necessary. Ignore it.
Comment 46•21 years ago
|
||
roc: it'd be nice if the box would be available for themes if there's only one scrollbar. This way View-Source on mac os (x) for example could not lose its scroll arrow.
Assignee | ||
Comment 47•21 years ago
|
||
Can you explain the problem there? I don't get it.
Comment on attachment 135713 [details] [diff] [review] fix bryner would be a better reviewer for this
Attachment #135713 -
Flags: superreview?(dbaron)
Attachment #135713 -
Flags: superreview?(bryner)
Attachment #135713 -
Flags: review?(dbaron)
Attachment #135713 -
Flags: review?(bryner)
Comment 49•21 years ago
|
||
Comment on attachment 135713 [details] [diff] [review] fix I tried this patch but mScrollCornerBox is always null, is part of the patch missing? Also, I think that there are five CSS files that style scrollbars which need to be taken into account.
Assignee | ||
Updated•21 years ago
|
Attachment #135713 -
Flags: superreview?(bryner)
Attachment #135713 -
Flags: review?(bryner)
Assignee | ||
Comment 50•21 years ago
|
||
Try this. There was a piece missing from the previous patch. I've hand edited the patch to remove some bits of another patch; hope it still applies cleanly. I verified that the styles in the theme CSS files are indeed applied. The colors I chose in the Mac CSS files are probably not correct but I can't figure out what they should be. BTW I can only find four relevant CSS files, where's the fifth?
Assignee | ||
Updated•21 years ago
|
Attachment #135713 -
Attachment is obsolete: true
Assignee | ||
Comment 51•21 years ago
|
||
Comment on attachment 135782 [details] [diff] [review] new patch ready for review again
Attachment #135782 -
Flags: superreview?(bryner)
Attachment #135782 -
Flags: review?(bryner)
Comment 52•21 years ago
|
||
Comment on attachment 135782 [details] [diff] [review] new patch themes/modern/global/scrollbars-mini.css
Comment 53•21 years ago
|
||
Re: comment 47 See bug 54688
Comment 54•21 years ago
|
||
Sorry ... I meant bug 56488. Darn bug 40896 (I think I typed that correctly) again!
Comment 55•21 years ago
|
||
Comment 56•21 years ago
|
||
Comment on attachment 135782 [details] [diff] [review] new patch Bitrotted slightly due to the GetTag deCOMtamination.
Comment 57•21 years ago
|
||
Comment on attachment 135782 [details] [diff] [review] new patch Looks ok, but I'd like to test with mac native scrollbars. I'll comment again after I've done that.
Comment 58•21 years ago
|
||
I applied the patch on Mac OS X (10.3) and I'm seeing artifacts in the scrollbar corner area, as shown in the screen shot.
Assignee | ||
Comment 59•21 years ago
|
||
Are these new artifacts or have they been visible before? What theme is in effect here? Is this loading "themes/classic/global/mac/nativescrollbars.css"? If so, perhaps -moz-Dialog isn't defined?
Assignee | ||
Comment 60•21 years ago
|
||
Getting the dumps from the layout debugger of the frames and views for this testcase might also help.
Assignee | ||
Updated•21 years ago
|
Attachment #135991 -
Attachment is patch: false
Attachment #135991 -
Attachment mime type: text/plain → text/html
Assignee | ||
Comment 61•21 years ago
|
||
Another thing would be to try changing the scrollcorner color in nativescrollbars.css to something like "green" and see if it has any effect whatsoever.
Comment 62•21 years ago
|
||
Ok, so the problem I saw was just because the firebird scrollbars.css wasn't patched. However, after doing so, I notice that the scrollbar corner is the wrong color. It's gray, whereas in a native app it's white.
Assignee | ||
Comment 63•21 years ago
|
||
OK, how about we check in this patch now and let the theme designers set the right color for 1.6final? (since I have no idea how to set the right color for Mac Firebird)
Comment 64•21 years ago
|
||
Comment on attachment 135782 [details] [diff] [review] new patch Ok, sure. Let's get the layout changes in now, then we can figure out whether -moz-dialog is the right color on Mac (and other platforms).
Attachment #135782 -
Flags: superreview?(bryner)
Attachment #135782 -
Flags: superreview+
Attachment #135782 -
Flags: review?(bryner)
Attachment #135782 -
Flags: review+
Assignee | ||
Comment 65•21 years ago
|
||
Comment on attachment 135782 [details] [diff] [review] new patch This patch fixes a longstanding polish issue. We need it for 1.6b so that theme designers can update their themes to set the correct color for the corner box where the two scrollbars meet.
Attachment #135782 -
Flags: approval1.6b?
Comment 66•21 years ago
|
||
Comment on attachment 135782 [details] [diff] [review] new patch a=asa (on behalf of drivers) for checkin to 1.6 beta.
Attachment #135782 -
Flags: approval1.6b? → approval1.6b+
Assignee | ||
Comment 67•21 years ago
|
||
checked in. up to the themes people to fix any remaining issues
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 68•21 years ago
|
||
*** Bug 223211 has been marked as a duplicate of this bug. ***
Comment 69•21 years ago
|
||
*** Bug 196929 has been marked as a duplicate of this bug. ***
Comment 70•21 years ago
|
||
*** Bug 227109 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•