433917 - Nested opacity causing painting errors, stuff not showing up

Status: VERIFIED FIXED

(Core :: Graphics, defect, P1)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, I don't see the first line in current trunk build at all and the second line disappears partly after selecting the text inside it and then collapsing the selection.

Not sure when this regressed (Ria?).

Comment 1

[Ria Klaassen (not reading all bugmail)]

Regression window is
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1205548200&maxdate=1205553779
Probably caused by bug 421422. 

Comment 2

[Martijn Wargers (dead)]

Ok, thanks, so that means this is a cairo issue then.

Comment 4

[Daniel Holbert [:dholbert]]

The testcase shows the bug on Linux (Ubuntu 8.04), as well.  First line is just completely white, unless I highlight it, which then gives me gray text on a white background.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I see the problem on Linux both before and after the given regression date.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Vlad: we need your eyes on this stat to tell us if we need to take a quick ride along for RC2 or if it can wait for 3.0.x

Comment 7

[Daniel Holbert [:dholbert]]

(In reply to comment #4)
> unless I highlight it, which then gives me gray text on a
> white background.

(Actually, it's not gray text, it's more like "brittle"/skinny black text.)

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The regression window I'm seeing on Linux (between the 2007-08-01-04-trunk and 2007-08-02-04-trunk nightlies) looks like it's most likely a previous cairo upgrade:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-08-01+02%3A00&maxdate=2007-08-02+05%3A00&cvsroot=%2Fcvsroot

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

I'll take a look here; I'm guessing we should just wait for 3.0.x, though.

Comment 10

[Stephen Sloan]

Looking closer at the site I reported in 435686 this is a standard phpbb forum using a pretty-much off-the-shelf css/style. I'd imagine this would render quick-reply textboxes unusable on quite a number of phpbb-based sites.

Comment 11

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This seems to fail if the outermost div (the one with just "opacity: 0.99") has a non-opaque background color, including the default 'transparent'.  Setting background: white or any other solid color results in correct rendering, setting background: rgba(255,0,0,0.5) does not.  Still looking.

Comment 12

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

I created a cairo testcase for this and sent it off to the cairo list -- Antoine tracked it down to a bug inside the MMX version of a pixman compositing routine (he didn't send his results to the list yet, but he will do so later -- I'll link).  We may be able to fix this for RC2 by disabling that particular MMX routine, but I'd rather just fix this for 3.0.1.

Comment 15

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This is fixed on the trunk.

Comment 16

[Martijn Wargers (dead)]

Fixed by what? Shouldn't this bug be marked fixed then?

Comment 17

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Fixed by an updated pixman; I seem to have missed the FIXED button.

Comment 18

[Bart Libert]

Should the testcase work in the latest nightlies, because I'm still having this problem at the moment.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1a2pre) Gecko/20080812020515 Minefield/3.1a2pre ID:20080812020515

Clean profile.

Comment 19

[Martijn Wargers (dead)]

Yes, the testcase should work in the latest nightlies.
I guess you should file a new bug on it, that it's not working for you. I assume that build uses the cairo libraries inside Firefox itself, right?

Comment 20

[Bart Libert]

I suppose it uses the built-in cairo libraries yes. Is there a way to make sure?

Comment 21

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Except that the bug is in pixman, and on linux you are likely using the X server's version of pixman, which still has the bug.

Comment 22

[Bart Libert]

Hmm, that's a possibility yes. Any way to force firefox to use the patched libraries on linux?

Comment 23

[Aakash Desai [:aakashd]]

verified FIXED on builds: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090414 Minefield/3.6a1pre ID:20090414030735

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090414 Shiretoko/3.5b4pre ID:20090414035212