Closed
Bug 44866
Opened 24 years ago
Closed 17 years ago
MNG supports neither Chromaticity correction nor ICC profiles
Categories
(Core :: Graphics: ImageLib, defect, P3)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
WONTFIX
Future
People
(Reporter: sicking, Assigned: tor)
References
()
Details
(Keywords: helpwanted)
The supplied URL goes to a page in the libmng testsute. The buttom image is a test for Gamma correction and ICC profiles. The different pictures of the flowsers should NOT look the same. tested with build 2000-07-07-20 on Win98SE
Reporter | ||
Comment 1•24 years ago
|
||
Sorry, a bit more investigation shows that Gamma seem to work but not chromaticity and ICC profiles. Updating Summary.
Summary: MNG dosn't support Gamma correction and ICC profiles → MNG dosn't support Chromaticity correction and ICC profiles
libmng has support for lcms, which performs these operations. The lcms code is currently c-99, so would require some grunt work to compile with ansi-c compilers. The bigger issue is that lcms is licensed under the LGPL. Adding mitchell for her opinion on the licensing issue. lcms homepage - http://www.abaforum.es/martim/lcms.htm
OS: Windows 98 → All
Hardware: PC → All
Comment 3•24 years ago
|
||
LGPL is compatible with the MPL and the NPL - it's even compatible with proprietary licenses. Moz.org may not want code under this license as part of the main tree (for that you'd need to ask them) but I can't imagine that there would be a problem with linking to it as an external library... The requirements of the LGPL basically just amount to letting the user know they can get the source, and using dynamic linking so they can replace the library with a modified version if they choose to. Moz uses dynamic linking anyway, and I'm sure the release notes will contain a whole bunch of legal stuff already. The only thing you have to worry about if using it as an external library is detecting at runtime whether it's present on the target system and using it only if so.
I doubt that any significant percentage of unix boxes have lcms installed, and can pretty much guarantee that no win32/macos boxes will have it lying around. Thus depending on an external library isn't practical. Possible alternate approach: Xcms on unix/X11, ColorSync on win32, and ??? elsewhere.
Comment 5•24 years ago
|
||
Doh. Yes, I'm too used to debian where depending on an external library is as simple as "Recommends: lcms" That doesn't rule out using it though; so long as dynamic linking is used and the appropriate legalese appears in the release notes, it's perfectly permissible to include it in the mozilla installation bundle. So the question is - what is moz.org's position on bundling LGPL'd code? Stuart.
Notes for future reference: X11: Xcms man -k Xcms MacOS: ColorSync http://developer.apple.com/techpubs/macos8/MultimediaGraphics/ColorSyncManager/colorsyncmanager.html Win32: ICM 2.0 http://msdn.microsoft.com/library/psdk/icm/icmstart_5i91.htm
Updated•24 years ago
|
QA Contact: elig → tpreston
Updated Mac OS ColorSync Manager URI: http://developer.apple.com/techpubs/macosx/Carbon/graphics/ColorSyncManager/colorsyncmanager.html
It's a little easier to see this bug at: http://www.libmng.com/MNGsuite/anke_simi_img.html
Reporter | ||
Comment 9•23 years ago
|
||
Could we perhaps use lcms now that the mozilla tree can handle non-MPL/NPL licencies? The libart library that is LGPLed lives happily in mozilla/other-licenses/libart_lgpl
Comment 10•22 years ago
|
||
This bug is caused by an out of date version of libmng. update to a version more recent than 1.0.4 to resolve this problem. this bug is found on the libmng website.
Comment 11•22 years ago
|
||
*** Bug 181676 has been marked as a duplicate of this bug. ***
Comment 12•22 years ago
|
||
opps. sorry about posting the other bug as a duplicate of this bug. these bugs and the solution may be related but theyare not the same.
Summary: MNG dosn't support Chromaticity correction and ICC profiles → MNG supports neither Chromaticity correction nor ICC profiles
Comment 14•21 years ago
|
||
comment 10 is mistaken as such the reason for dependancy on bug 181676 should not be due to my mistaken comment 10, but it should be left as a dependancy because it would be unwise to try to fix this shortly before libmng 1.0.5 final is released as doing that may cause problems when we update it.
Comment 15•21 years ago
|
||
using build 2003030908 on Win2k, I crash when displaying the URL http://www.libmng.com/MNGsuite/anke_diff_img.html : TB17913211K. Perhaps a regression from new libmng 1.05, bug 181676 ?
Keywords: crash,
stackwanted
Whiteboard: TB17913211K
Reporter | ||
Comment 16•21 years ago
|
||
this bug has nothing to do with a crash. Please file a new bug on that
Keywords: crash,
stackwanted
Whiteboard: TB17913211K
Comment 17•21 years ago
|
||
Works For Me, Moz 1.3 20030312, Win95. The colors all look correct, so color management is working properly. Perhaps this bug should be closed. Glenn
Comment 18•21 years ago
|
||
Using a 4/28 build at the URL in comment 8, I still see a problem with the second set of images. "If the image at center-bottom looks as strange as the one on the left, your software *does not* handle ICC profiles."
Comment 19•21 years ago
|
||
Oops, you're right. The images in the main URL look correct, but the ones in comment #8 display swapped color channels. So Moz 1.3 doesn't WFM. Glenn
Comment 20•21 years ago
|
||
"The images in the main URL look correct" is actually incorrect behaviour. To pass the test, they should appear with swapped colors. Sorry.
Updated•21 years ago
|
Comment 21•19 years ago
|
||
*** Bug 288727 has been marked as a duplicate of this bug. ***
Comment 22•17 years ago
|
||
Since bug # 18574 has been marked WONTFIX, this one should also be marked WONTFIX.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•