Closed Bug 4886 Opened 25 years ago Closed 25 years ago

Get new messages gets all messages, not just new.

Categories

(MailNews Core :: Backend, defect, P2)

Product:
MailNews Core
Component:
Backend
Platform:
All
Linux
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: laurel, Assigned: mscott)

Details

Using build 1999040908
Linux
Using build 1999040818
Win95

Getting new messages gets old messages, too.  Inbox thread pane displays
duplicate messages after every get message.

Verified over several users on Linux and Windows.

1.  Tasks|Messenger.
2.  Select Inbox.  Folder pane displays messages. (Sorted by thread)
3.  Send yourself a message, get new messages.
Result:  Thread pane now displays a duplicate set of Inbox messages. If you
don't notice this in a threaded sort because maybe your inbox is fairly
large,sort by subject and you'll see there are duplicates of every message.
Priority: P3 → P2
QA Contact: 4080 → 4114
This should be added to the release note since it very noticable behavior if it
can not fixed for M4.
updated release note tracking bug:
http://bugzilla.mozilla.org/show_bug.cgi?id=4516
So... after talking to rhp about the symptom of still seeing xml parsing errors
after getting new mail, he claims the xml parsing errors are really resulting
from this (#4886) bug getting (duplicate) old messages along with the new.  I'm
waiting for rhp to comment in the other (#4784) bug before closing that one and
providing a tracking to this one.

This means that a user would have to remove .msf files before launch to see new
or the duplicates of old messages without encountering an xml parsing error.
I'm a little confused. Does removing bogus .msf files fix this bug?
No, removing .msf files do not help in the long run.
Here's some scenarios:

(1) Start Seamonkey (no .msf files around)
(2) Get Mail
(3) You'll see that get new msgs gets all messages and you'll see all your Inbox
msgs duplicated.
(4) You will have this problem until you delete your .msf file.  However, the
next time you do Get Msgs, you'll have the same problem.

As a side effect, after you do a Get Msgs and select an older msg, you'll see
the .xml parser bug.  You must delete .msf files every time too.
Assignee: phil → bienvenu
Sounds like the bug where downloading mail corrupts the headers. Reassigning to
bienvenu@netscape.com
No, Lisa's comments aren't entirely correct:
Deleting the msf files will not clear the duplications from your Inbox at all.
Deleting msg files will allow you to read all messages without encountering the
xml parsing error.  Again, deleting msf files does nothing for the main bug,
just helps with its side effect of xml errors.
Assignee: bienvenu → mscott
I talked to David, said it sounds like a popstate problem.  I then talked to
Scott M. he said to reassign this to him he'll look at it.
Status: NEW → ASSIGNED
Target Milestone: M5
Would it be possible for one of you to email me your popstate.dat file?
(Preferabbly one that isn't swamped with 100s of messages in it but I'll take
anything you've got).

You can find this file in the same directory as your mail folders and .msf
files. It's called popstate.dat
Setting target fix milestone to M5!
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
I have a fix for this bug! I just checked it in. For those who are interested,
our hash table was bogus and not being set up correctly. So when we parsed the
popstate.dat file and added all known uids for the msgs to a hash table, we
weren't really adding the entries. Then when getting the uids from the server
for the inbox, we would think we haven't seen any of them. Hence, we'd download
all the messages again.

To test:
(1) Since your Inbox and Inbox.msf is probably already corrupted for this bug
(i.e. your Inbox file already has multiple copies of the messages), I'd suggest
deleting the Inbox folder or going into 4.5 and cleaning up the Inbox folder
then compacting the folder.

(2) Okay, now in mozilla, get new messages. Verify that all the messages that
are in the inbox are in fact downloaded and added to your inbox. Take brief
notice of how much time it takes to do this.

(3) Now send yourself one or more messages. Hit get new msgs again. Notice that
we only download the NEW messages and not everything again. Notice that it
should be *MUCH* faster than it was in step (2) because we are only downloading
the new messages. verify that you don't have any duplicates in the folder.

(Look for this in the 4/27 builds)

-Scott "no M5 bugs" MacGregor
Thanks, Scott! We'll look for your fix in tomorrow's release build.
April 27 Linux build, Can't be sure it's the same thing, but I'm getting XML
Parsing errors for every message. Before running, I deleted my
~/.mozilla/registry and all of my .msf files.

console says:
"XML Error in file 'file:///var/tmp/tempMessage.eml?header=only', Line Number:
1, Col Number: 1, Description: not well-formed
Source Line: </message>"

See http://jazz/users/scurtis/popstate.dat.

(April 27 build just came out; I haven't seen an announcement yet, but it's in
the "current" directory)

Leaving as resolved fixed until someone confirms what I'm seeing, since I
haven't been involved with this bug.
Interesting...I thought display messages on Linux crashed --> Bug #5477. Sounds
like you get that far.....Maybe it isn't crashing anymore...that would be
nice....
5477 is marked as having been fixed on 4/24, though it's not yet marked as
verified. (I hadn't tested Linux builds while that bug was a blocker.)

However, FWIW, I'm seeing the same XML parsing problem with the April 26 Linux
build, too. If I go back to my April 19th build, I get no XML parsing errors
when I start with no .msf files.
Stacy, are we talking about the same bug in Bug #5477. We just created it
yesterday (26th) and I'm pretty sure we don't have a fix for it yet.
Sorry, I had misstyped 5447. Regardless, I'm not seeing a crash, I'm seeing the
parsing error. Your call...I can leave this info here, or can start a new
one....
Hmm why don't you add yourself to 5447 and put your comments there. I think what
your seeing is a separate bug from the one I fixed here. I think it is the same
problem we're having on our debug builds with displaying any message in Linux
and not just messages returned by get new mail. But I could be wrong...
Remember all, this bug is the Get Message gets old messages problem. The XML
parsing error(s) was told to be a side effect of the main problem.

I'm not seeing the original problem of getting all/old messages using the 4/27
linux build.  In any case we should not call it verified until we see it works
on Windows, too.

Side note (5477): I'm crashing on display message (usually the second one) and
am also seeing an xml error.
Please note, all, in bug #4784, it was stated about the XML parsing error: "Will
track this symptom under #4886." However, alec has a good explanation for why
its current manifestation might indeed be #5477.
This bug is tracking display of new messages and should not be (as Stacy pointed
out) confused with 5477. We have a bug displaying messages not related to
showing new messages. That's 5477. We had a separate bug which prevented us from
even getting that far with new messages which I fixed here.

I suspect we will not be able to mark this bug as verified until 5477 is fixed.
But they are two separate bugs. Hope this makes some sense.
I missed Laurel's comments...She's right this bug is aimed at fixing multiple
downloads of the same messages when you get new mail. It doesn't have anything
to do with display which is a problem on Linux right now and is covered in the
other bug.
This is working much better but we're still having some problems with
displaying msgs, bug fixes for them have gone in today. I will wait to verify
this with the 4/28 build per Scott's suggestions.
Whiteboard: Waiting for 4/28 build to verify, per mscott
Updated info for 4/29 builds:  Windows OK. Can't verify for Mac and Linux, ref
bug #5736.
Whiteboard: Waiting for 4/28 build to verify, per mscott → Waiting for bug 5736 to be fixed before I can test this on linux
Using 1999043008 on win32 this appears to be fixed in a simple test.  Can't
check linux yet.
Status: RESOLVED → VERIFIED
Using linux 1999050308 this is now working, now both win32 & linux work.
Verified as fixed.
Whiteboard: Waiting for bug 5736 to be fixed before I can test this on linux
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.