596080 - testInputFocus failures on Windows

Status: RESOLVED INVALID

(DevTools :: General, defect)

Description

[David Dahl :ddahl]

For some reason, this test is failing on windows now. (Locally)

It is kind of strange:

// Tests to ensure that the input box is focused when the console opens. See
// bug 579412.
function testInputFocus() {
  let hud = HUDService.getHeadsUpDisplay(hudId);
  let inputNode = hud.querySelectorAll(".jsterm-input-node")[0];
  is(inputNode.getAttribute("focused"), "true", "input node is focused");
}


Shouldn't we be testing for true and not "true" (string)?

I tried it this way and it still fails.  Passes on my linux machine.

i may have to disable it if it shows up on tinderbox - until we break out the tests.

Comment 1

[David Dahl :ddahl]

also, this test passes on Mac. Anyone else see this on windows?

Comment 2

[Mihai Sucan [:msucan]]

I talked to Julian about this a month ago or so. I see this failure on my system as well. It happens every now and then.

Problem is that the check happens to soon before the actual focus occurs. It's not a problem with how the value is checked.

The fix should be to actually wait for the focus event, if the input is not focused yet.

Comment 3

[Mihai Sucan [:msucan]]

David: Is this bug still valid?

Since the tests have been split I never been able to reproduce this issue. Perhaps there's no longer anything to fix. The test file browser_webconsole_bug_579412_input_focus.js looks fine.

Thoughts?

Comment 4

[David Dahl :ddahl]

(In reply to comment #3)
> David: Is this bug still valid?
> 

probably not.