70755 - shift-click and ctrl-click doesn't work in the tree widget

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Christopher Blizzard (:blizzard)]

This bug is filed as fallout from bug #60703.  Shift-click and ctrl-click don't 
work in trees anymore.  This is because ( according to hyatt ):

[ begin ]

------- Additional Comments From David Hyatt 2001-03-02 11:41 -------

The patches to the tree XBL are incorrect.  To quote Peter Linss,

READ THE SPEC.

You just added code to the tree handler that imposed a filter on the event
handler.  This means it will no longer be matched when CTRL or META are pressed.
 The correct code should have just patched the button == 1 check to become
button == 0.

A filter (the button attribute) should not have been placed on the handler.

Please fix this right now.




------- Additional Comments From David Baron 2001-03-02 12:45 -------

hyatt:  Do your comments apply to all of treeEditable.xml, outlinerBindings.xml,
and treeBindings.xml, or just some of them?


------- Additional Comments From David Hyatt 2001-03-02 13:19 -------

The code that jst had questions about is the code that was incorrectly modified.
 That is treeBindings.xml (and presumably outlinerBindings.xml) as well.



------- Additional Comments From David Hyatt 2001-03-02 13:23 -------

If you need a bug, the regression caused is

"Ctrl+Click no longer works in trees."



------- Additional Comments From David Hyatt 2001-03-02 13:27 -------

The fix is to revert the file back to the way it was and then just do a straight
substitution everywhere button is used with a value of 1.

[ end ]

No patch yet.

Comment 1

[R.K.Aa.]

also reported in bug 70709 and bug 70744.

Comment 2

[Christopher Blizzard (:blizzard)]

*** Bug 70709 has been marked as a duplicate of this bug. ***

Comment 3

[Christopher Blizzard (:blizzard)]

*** Bug 70744 has been marked as a duplicate of this bug. ***

Comment 4

[Christopher Blizzard (:blizzard)]

I marked them as dups of this one since this one has information about what's 
actually causing it.

Comment 5

[Blake Ross]

Attachment: patch

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Do you also need to fix treeEditable.xml?

Comment 7

[Blake Ross]

Attachment: can't hurt...

Comment 8

[Blake Ross]

someone sr these?

Comment 9

[Blake Ross]

Fix checked in.

Comment 10

[Bill Haughton]

under www.neopets.com  game = neggsweeper,  you indicate bombs by using
shift-click  or  ctrl-click,  neither of which works,  so the game is not
playable.

I'm bummin' ! ! !

Comment 11

[John Morrison]

Hmm, well, I don't have my neopets account handy (maybe Blake does), but I 
doubt that that game is using a XUL Tree widget, which is what this bug is 
about.

Could you file a bug about neopets under Browser-General. Thanks.

Comment 12

[Brant Gurganus]

VERIFIED in 2002123108