78374 - Can't dynamically switch themes

Status: VERIFIED INVALID

(Core Graveyard :: Skinability, defect, P2)

Description

[Mike Pinkerton (not reading bugmail)]

- 5/1 commercial opt build
- try to switch from modern to classic with View:ApplyTheme menu

expected:
- get classic

actual:
- nothing happens

Comment 1

[Mike Pinkerton (not reading bugmail)]

it even ignores me when i use the prefs panel...

...however when I quit and re-launch, the new theme is there.

Comment 2

[Mike Pinkerton (not reading bugmail)]

ok, after a restart of the app, it switches fine. wtf?

Comment 3

[Mike Pinkerton (not reading bugmail)]

from irc:

kerz: pinkerton: i think that's known
kerz: pinkerton: it throws an exception when you switch, but prefs picks up the 
change

Comment 4

[Blake Ross]

*** Bug 78385 has been marked as a duplicate of this bug. ***

Comment 5

[Joe Hewitt (gone)]

-> skinability

Comment 6

[Paul Chen]

nav triage team:

Reassigning to mcafee

Comment 7

[selmer (gone)]

What's up with this bug?  Is it going to make it in this week?  If not, we
should create a dialog stating the theme change isn't effective until restart!

Comment 8

[Chris McAfee]

This looks like it's working for mozilla linux & w2k.
I can reproduce this with commercial w2k, and it's only 
one way: modern -> classic fails until restart, but 
classic -> modern always seems to work.

Comment 9

[Asa Dotzler [:asa]]

tested mac, linux and win32 mozilla nightly builds 051708/4
starting browser in classic switching to modern and back to classic worked fine
(except some alignment and update problems with the URL bar see bug 61991).
starting browser with modern and switching to classic and back to modern worked
fine.

see also bug 78580 and 81197

Comment 10

[Mike Pinkerton (not reading bugmail)]

that's not what i am seeing with the 5/16 builds on mac. if i start in modern and 
switch to classic, nothing happens.

Comment 11

[Viswanath Ramachandran]

pink - do you have a problem with mozilla? or does the problem only happen in 
commercial?

Comment 12

[Mike Pinkerton (not reading bugmail)]

i'm running commercial install bits from 5/16

Comment 13

[Viswanath Ramachandran]

yes I think this is a commercial only issue at this point. 
Vishy

Comment 14

[Jason Kersey]

It's pretty clear that we should encourage a restart after theme switch, as any
open windows during the switch still have problems, like the modern url bar
after switching to classic.  This would eliminate a lot of headache i think.

Comment 15

[Paul Chen]

nav triage team:

Since this is a commercial build issue, created new bugscape bug 5056 to track 
this issue. Marking invalid.

Comment 16

[Patty Mac]

Verified dup.