7927 - [PP] Mac - need to be able to disable menu items

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Simon Fraser [no longer active]]

There seems to be no way of disabling of menu items now. Adding a 'disabled'
attribute in XUL does nothing, and widget seems to contain no code to do the
disabling.

Comment 1

[saari (gone)]

This isn't happening until M9 on MacOS when dynamic menus come in.

Comment 2

[Claudius Gayle]

Pip, if you agree, could you transfer the dependency when you verify?


*** This bug has been marked as a duplicate of 4960 ***

Comment 3

[cpratt]

I don't believe this is a duplicate of 4960. 4960 asks that menu items be
disabled when they do not 'make sense' contextually, eg Paste should be disabled
whenever the clipboard is empty, or when focus is not on/in an item that can be
pasted into. This bug seems to have to do with 'disabled' attributes in XUL
that do nothing (on the Mac only if I read this bug correctly). As the QA
'owner' of 4960, I'd like to keep the issues separate: when it is possible to
disable menu items, close this one out. After that, I'll make sure that we are
in face disabling menu items appropriately according to context. OK?

Reopening bug, clearing resolution.

Comment 4

[phillip]

yeah, that makes sense. once the functionality is there (this bug),
then it will be possible to fix bug 4960.

Comment 5

[saari (gone)]

I just pushed mac dynamic menus to M10, so I'm pushing this too

Comment 6

[saari (gone)]

Ok, Mac dynamic menus are in, and I just added the code to obey the enabled/
disabled state for menu items.

Comment 7

[Paul MacQuiddy]

Sorry for spam, re-assigning phillip's QA contact XPToolkit/XPWidget bugs to
claudius due to restructure

Comment 8

[Paul MacQuiddy]

verified