80970 - offline indicators for search, history, subscribe not working

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[(not reading, please use [e-mail] instead)]

offline indicators for search, history, subscribe not working

if there are more windows that have offline indicators (besides editor, msg 
compose, mail 3pane, std alone mail window and browser, which are working), 
we'll need to fix them or remove the offline indicator.

for example, does history need an offline indicator?  

if these windows do have an offline indicator, do they need a "File | Work 
Offline..." menu item?

currently, to get the utitlityOverlay to work I needed to have something 
observe the "Communicator:WorkMode" broadcaster

Comment 1

[(not reading, please use [e-mail] instead)]

adding jglick to the cc list.

should history, search and subscribe have offline indicators?

what are the UI guidelines for deciding which windows have them, and which 
don't?

Comment 2

[David :Bienvenu]

my suggestion is that if your window doesn't have a task bar, it probably
doesn't need an offline indicator/switcher.

Comment 3

[timeless]

sure, except that search and history should have a taskbar.

Comment 4

[grylchan]

*** Bug 74351 has been marked as a duplicate of this bug. ***

Comment 5

[grylchan]

*** Bug 79801 has been marked as a duplicate of this bug. ***

Comment 6

[grega]

marking nsenterprise-.

Comment 7

[[e-mail]]

Actually to get the utilityOverlay to work you need to overlay the broadcaster
in the first place...

Comment 8

[grylchan]

Nominating for nsbeta1 because of the advance search
windows for Mail and advance search for LDAP/Add book.

This is more for LDAP/Add book as many users would be using
this? And the confusion comes from they are offline but
adv search window still shows them online (ie button is
connected instead of disconnected). Everything still
works as expected, just the icon might confuse them.

See ldap offline add book bug 135003

Comment 9

[Michael Buckland]

Discussed in Mail News bug meeting.  Decided to minus this bug.

Comment 10

[R.K.Aa.]

*** Bug 138787 has been marked as a duplicate of this bug. ***

Comment 11

[Ken Harris]

I don't see why history should have a taskbar.  Its only purpose seems to be
to show the URL, which is shown in the table, anyway.  I'd rather display one
more line of the window's data than display the line that's selected twice.

(Oh, and on Mac it prevents the bottom scrollbar-arrow from being hidden by
the resize-box, but that's a different bug.)

Comment 12

[Rene Pronk]

Attachment: Patch for the history and search offline indicator

Got a patch. I assume that by the indicator for the subscribe the newsgroup
subscribe was meant. Since the icon is gone now I assume that fixed. Please
r,sr the patch. Since this is my first Mozilla patch it might be a
working-but-solving-the-wrong-problem patch.

Comment 13

[laurel]

*** Bug 170203 has been marked as a duplicate of this bug. ***

Comment 14

[Rene Pronk]

Is there anyone here that can r,sr or should I ask someone in
netscape.public.mozilla.reviewers? The patch I wrote is already 2 months old.
Would be nice to get it into the trunk (possibly before 1.2 branch?).

Comment 15

[Scott Collins]

First, have you read

  http://www.mozilla.org/hacking/reviewers.html

To get review, you pick the appropriate party to review, and email them
directly.  Who should review?  At least the module owner or a peer of the module
owner.  You probably already know the module owner you are working with, but you
can double-check at

  http://www.mozilla.org/owners.html

Only after you have a review in hand to you ask a super reviewer (else, it's a
waste of their time, and there aren't enough sr's to waste their time). 
Super-reviewers are listed in that first doc I cited.

(also sending this directly as email)

Comment 16

[Scott Collins]

Hmmm, your email address had permanent fatal errors in delivery.  Not a good sign.

Comment 17

[Rene Pronk]

Yes I read it, but I figured some of the peers are listed in the cc list and the
reporter is one, so why not try it here, but you're right, I'll try it the
official why.

I don't know anything about the fatal errors, I received both your mails.

Comment 18

[[e-mail]]

Comment on attachment 97460 [details] [diff] [review]
Patch for the history and search offline indicator

r=me but only on the changes to history.xul as the offline indicator works in
the search dialog.

Comment 19

[Alec Flett]

Comment on attachment 97460 [details] [diff] [review]
Patch for the history and search offline indicator

sr=alecf

Comment 20

[Rene Pronk]

Great. Anyone volunteering to check it in? I have no rights.

Comment 21

[Christian :Biesinger (don't email me, ping me on IRC)]

this was checked in 01/03/2003 05:51 by neil, should it be marked fixed?

Comment 22

[Rene Pronk]

Works now. Marking as fixed.

Comment 23

[benc]

VERIFIED: Linux, Mozilla 1.6f
offline-online working for history