81872 - Buttons in modern have a square outline when pushed down

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[Tim Smith]

From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 5.5; Windows NT 5.0)
BuildID:    2001051804

If you push down one of the buttons in the pretty new modern theme they have a 
box outline around them.  Something is screwed up switching to the indented 
gifs.

Reproducible: Always
Steps to Reproduce:
1.Open Mozilla
2.Make sure you're in modern
3.Push any button down

Actual Results:  A square nasty shows up around the indented gif


Expected Results:  A pretty indented gif

Comment 1

[R.K.Aa.]

dup

*** This bug has been marked as a duplicate of 78221 ***

Comment 2

[Blake Ross]

Time to stop dupping against that bug...

Comment 3

[R.K.Aa.]

Bug 79689 about the same issue was a dup of bug 78221 so the issue is known.
Hewit says modern3 is still not 100% finished.

If you look at the actual gif's in jar you'll see that this isn't a bug as such
- it's how the gifs currently look.
If you compare against the newly checked in "clicked-buttons" in mailnews, you
see which look they all eventually are meant to have.

There's nothing new about this bug. Dup'ing it seemed reasonable.

Comment 4

[Joe Hewitt (gone)]

*** Bug 81979 has been marked as a duplicate of this bug. ***

Comment 5

[Patty Mac]

Verified dup.


*** This bug has been marked as a duplicate of 81979 ***

Comment 6

[Patty Mac]

dup.

Comment 7

[Blake Ross]

Um...we can't have them marked as dups of themselves :-) (why does Bugzilla 
allow this?)

Comment 8

[Patty Mac]

Blake, I'm sorry but I think this bug is a dup of the other bug# 81979.

Comment 9

[Blake Ross]

My point is that this bug was marked as a duplicate of bug 81979, and that one 
was marked as a duplicate of this bug, so there were no open bugs...I don't 
care which way the bugs are duped, but one needs to remain open.

Comment 10

[ohely]

Bug 82249 appears to be a duplicate of this one.

Comment 11

[R.K.Aa.]

This is actually a dup of bug 79689 :)

Comment 12

[gary_Cope]

*** Bug 82249 has been marked as a duplicate of this bug. ***

Comment 13

[Joe Hewitt (gone)]

*** Bug 79689 has been marked as a duplicate of this bug. ***

Comment 14

[chris hofmann]

when are the new images going to be ready?
I think we can live with the current state for 0.9.1, but
if we don't want to we need to get the images landed quickly.

Comment 15

[Gilles Durys]

*** Bug 82986 has been marked as a duplicate of this bug. ***

Comment 16

[Peter Lairo]

It would look cool if the round buttons (back, forward, reload & stop) pressed
INTO the surrounding round hole.

Or, to be consistent with the other buttons, if it "indented".

I would also suggest adding the keywords: UI, polish; and also remove the extra
space in the summary (between "have" and "a").

Comment 17

[Joe Hewitt (gone)]

I have the images in my tree, just need approval to check in.  There are no code
changes involved, just 4 new gif images.

Comment 18

[Christopher Blizzard (:blizzard)]

a=blizzard for 0.9.1

Comment 19

[Joe Hewitt (gone)]

fixed

Comment 20

[Patty Mac]

Still seen on windows and Linux (Commerical build: 2001-05-29-09-trunk)

Comment 21

[Dave]

It's gone on 2001053009/Linux...

Comment 22

[Patty Mac]

Dave, I've verfied on windows 98 in modern theme (commercial build:
2001-05-30-09-trunk), it's already fixed. Marking verified.

Comment 23

[Peter Lairo]

The new pressed buttons look good. Just one minor suggestion: Since the nav
buttons are at the TOP of the screen, one would be looking UP at the buttons.
Therefore, when looking UP at an indented button, one would more likely see the
TOP portion of the "shaft" (the hole the button moves into) and not the bottom
portion. 

I suggest moving the visible part of the "shaft" from the bottom to the top.

Ah heck, I'll file a bug on this... ;)

Comment 24

[Peter Lairo]

OK, I filed bug 83446 for my previous comment.