Closed Bug 847367 Opened 11 years ago Closed 11 years ago

Build fails on namespace conflict with EGLSurface in AndroidBridge.cpp

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox20 unaffected, firefox21 fixed, firefox22 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 22
Tracking Flags:
Tracking Status
firefox20 --- unaffected
firefox21 --- fixed
firefox22 --- fixed

People

(Reporter: cwiiis, Assigned: cwiiis)

References

Details

Attachments

(1 file)

Fix namespace conflict with EGLSurface in AndroidBridge.cpp
1.23 KB, patch
blassey
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
I see a build error where mozilla:EGLSurface has a namespace conflict with EGLSurface - oddly, I only see this when building for arm, but it's a simple fix.
r?blassey in case I've made a silly C++ mistake.
Attachment #720647 - Flags: review?(blassey.bugs)
Attachment #720647 - Flags: review?(blassey.bugs) → review+
(In reply to Chris Lord [:cwiiis] from comment #0)
> oddly, I only see this when building for arm

y u use old ndk?
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #4)
> (In reply to Chris Lord [:cwiiis] from comment #0)
> > oddly, I only see this when building for arm
> 
> y u use old ndk?

Oh whoops, had updated my x86 mozconfig and not my arm one :) Well ftr, you can still use r5c now, if you so wish...
https://hg.mozilla.org/mozilla-central/rev/72854a54aac6
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Comment on attachment 720647 [details] [diff] [review]
Fix namespace conflict with EGLSurface in AndroidBridge.cpp

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 844275
User impact if declined: can't build fennec with some compiler configurations
Testing completed (on m-c, etc.): on m-c, aurora try build at https://tbpl.mozilla.org/?tree=Try&rev=26b79db37644
Risk to taking this patch (and alternatives if risky): fennec only, low risk
String or UUID changes made by this patch: none
Attachment #720647 - Flags: approval-mozilla-aurora?
Comment on attachment 720647 [details] [diff] [review]
Fix namespace conflict with EGLSurface in AndroidBridge.cpp

bug 844275 recently got approved for aurora, approving uplift of this to avoid fennec build issues with some compiler configurations
Attachment #720647 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: