Closed Bug 847429 Opened 11 years ago Closed 11 years ago

Fix build errors for OS X builds introduced by bug 844275

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
macOS
defect
Not set
major

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 847367

People

(Reporter: MarcoZ, Assigned: kats)

Details

Attachments

(1 file)

Current Mozilla-Inbound, when built on OS X for Firefox for Android, gives the following error messages:
http://pastebin.mozilla.org/2193962
Version: Firefox 11 → Trunk
17:04:56 - marcoz: edmorley: Question out of curiosity: Do you know why our build system doesn't catch errors like the one that lead to bug 847429?

Presume toolchain differences?
Flags: needinfo?(mh+mozilla)
Yeah, these are probably toolchain differences. Somebody who was building android with gcc-4.4 reported the same error but it went away after upgrading NDK to r8c and using gcc-4.6. This shouldn't be too hard to fix regardless.
Component: Add-on Manager → General
Assignee: nobody → bugmail.mozilla
Flags: needinfo?(mh+mozilla)
Attached patch Possible fixSplinter Review
Marco, can you test this fix? It's probably quicker than waiting for me to downgrade my toolchain to test it.
Attachment #720767 - Flags: review?(marco.zehe)
Actually this seems to have been fixed.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Attachment #720767 - Flags: review?(marco.zehe)
No longer blocks: 844275
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: