Bug 1570499 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Bug 1215411 defined `MOZ_FALLTHROUGH` using clang's nonstandard attribute `[[clang::fallthrough]]`. After we compile as C++17 by default (bug 1560664), we can replace `MOZ_FALLTHROUGH` with standard C++17 attribute `[[fallthrough]]`.

https://en.cppreference.com/w/cpp/language/attributes/fallthrough

TBD whether we can then remove the `MOZ_FALLTHROUGH_ASSERT` macro (from bug 1235277) that works around clang bug https://llvm.org/bugs/show_bug.cgi?id=25966.
Revision 1 by
on 
Bug 1215411 defined `MOZ_FALLTHROUGH` using clang's nonstandard attribute `[[clang::fallthrough]]`. After we compile as C++17 by default (bug 1560664), we can replace `MOZ_FALLTHROUGH` with C++17's standard `[[fallthrough]]` attribute.

https://en.cppreference.com/w/cpp/language/attributes/fallthrough

TBD whether we can then remove the `MOZ_FALLTHROUGH_ASSERT` macro (from bug 1235277) that works around clang bug https://llvm.org/bugs/show_bug.cgi?id=25966.

Back to Bug 1570499 Comment 0